-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix PreemptiveFastFailInterceptor clean repeatedFailuresMap issue #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I add a HBASE_CLIENT_FAILURE_MAP_CLEANUP_INTERVAL_MS constant value to configure failureMapCleanupIntervalMilliSec, then the HBASE_CLIENT_FAST_FAIL_CLEANUP_MS_DURATION_MS constant value will configure fastFailClearingTimeMilliSec. |
🎊 +1 overall
This message was automatically generated. |
Is there an Apache HBase JIRA associated with this PR? |
Interesting, do you use Preemptive Fail Fast feature in your production? Do you think the feature introduced in HBASE-16388 can also solve your problem? Thanks. |
No, i am learning hbase with source code. |
No, i am learning hbase with source code. |
@jxxiangwen Welcome. FYI, fixing stuff, there is an associated HBase JIRA. File one over here... https://issues.apache.org/jira/projects/HBASE/issues/HBASE-22148?filter=allopenissues Shout if need help. Thanks for contributing. |
I have create a issue, https://issues.apache.org/jira/browse/HBASE-22292. What do I need to do next? |
Good. Thanks. Is it the case that the answer to @Apache9 question repeated below is no? .bq Do you think the feature introduced in HBASE-16388 can also solve your problem? If so, I'll merge this. On merge, I'll refer to issue (when you open PR, subject is usually the JIRA subject FYI). |
@saintstack HBASE-16388 can not solve the problem, this problem will disable fast fail mode . |
in PreemptiveFastFailInterceptor, the failureMapCleanupIntervalMilliSec and fastFailClearingTimeMilliSec are used to clean repeatedFailuresMap, but the HConstants.HBASE_CLIENT_FAST_FAIL_CLEANUP_MS_DURATION_MS seem to config fastFailClearingTimeMilliSec, and fastFailClearingTimeMilliSec has no config value. so in occasionallyCleanupFailureInformation function the else if branch will be always true.