Skip to content

fix PreemptiveFastFailInterceptor clean repeatedFailuresMap issue #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

jxxiangwen
Copy link
Contributor

in PreemptiveFastFailInterceptor, the failureMapCleanupIntervalMilliSec and fastFailClearingTimeMilliSec are used to clean repeatedFailuresMap, but the HConstants.HBASE_CLIENT_FAST_FAIL_CLEANUP_MS_DURATION_MS seem to config fastFailClearingTimeMilliSec, and fastFailClearingTimeMilliSec has no config value. so in occasionallyCleanupFailureInformation function the else if branch will be always true.

@jxxiangwen
Copy link
Contributor Author

I add a HBASE_CLIENT_FAILURE_MAP_CLEANUP_INTERVAL_MS constant value to configure failureMapCleanupIntervalMilliSec, then the HBASE_CLIENT_FAST_FAIL_CLEANUP_MS_DURATION_MS constant value will configure fastFailClearingTimeMilliSec.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 277 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 28 Maven dependency ordering for branch
+1 mvninstall 279 master passed
+1 compile 45 master passed
+1 checkstyle 51 master passed
+1 shadedjars 269 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 98 master passed
+1 javadoc 38 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 265 the patch passed
+1 compile 45 the patch passed
+1 javac 45 the patch passed
+1 checkstyle 52 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 288 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 537 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 109 the patch passed
+1 javadoc 38 the patch passed
_ Other Tests _
+1 unit 156 hbase-common in the patch passed.
+1 unit 189 hbase-client in the patch passed.
+1 asflicense 20 The patch does not generate ASF License warnings.
2881
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-183/1/artifact/out/Dockerfile
GITHUB PR #183
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux fe07ffba9f03 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / c3c48f3
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-183/1/testReport/
Max. process+thread count 314 (vs. ulimit of 10000)
modules C: hbase-common hbase-client U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-183/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

Is there an Apache HBase JIRA associated with this PR?

@Apache9
Copy link
Contributor

Apache9 commented Apr 23, 2019

Interesting, do you use Preemptive Fail Fast feature in your production? Do you think the feature introduced in HBASE-16388 can also solve your problem?

Thanks.

@jxxiangwen
Copy link
Contributor Author

Is there an Apache HBase JIRA associated with this PR?

No, i am learning hbase with source code.

@jxxiangwen
Copy link
Contributor Author

Interesting, do you use Preemptive Fail Fast feature in your production? Do you think the feature introduced in HBASE-16388 can also solve your problem?

Thanks.

No, i am learning hbase with source code.

@saintstack
Copy link
Contributor

@jxxiangwen Welcome.

FYI, fixing stuff, there is an associated HBase JIRA. File one over here... https://issues.apache.org/jira/projects/HBASE/issues/HBASE-22148?filter=allopenissues Shout if need help. Thanks for contributing.

@jxxiangwen
Copy link
Contributor Author

@jxxiangwen Welcome.

FYI, fixing stuff, there is an associated HBase JIRA. File one over here... https://issues.apache.org/jira/projects/HBASE/issues/HBASE-22148?filter=allopenissues Shout if need help. Thanks for contributing.

I have create a issue, https://issues.apache.org/jira/browse/HBASE-22292. What do I need to do next?

@saintstack
Copy link
Contributor

Good. Thanks.

Is it the case that the answer to @Apache9 question repeated below is no?

.bq Do you think the feature introduced in HBASE-16388 can also solve your problem?

If so, I'll merge this. On merge, I'll refer to issue (when you open PR, subject is usually the JIRA subject FYI).

@jxxiangwen
Copy link
Contributor Author

Good. Thanks.

Is it the case that the answer to @Apache9 question repeated below is no?

.bq Do you think the feature introduced in HBASE-16388 can also solve your problem?

If so, I'll merge this. On merge, I'll refer to issue (when you open PR, subject is usually the JIRA subject FYI).

@saintstack HBASE-16388 can not solve the problem, this problem will disable fast fail mode .

@saintstack saintstack merged commit 6855143 into apache:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants