HDFS-9895. Push up DataNode#conf to base class #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public DNConf(Configuration conf) { | ||
| this.conf = conf; | ||
| socketTimeout = conf.getInt(DFS_CLIENT_SOCKET_TIMEOUT_KEY, | ||
| public DNConf(final DataNode dn) { |
There was a problem hiding this comment.
The dn.getConf() object is not referenced outside the constructor so you can just pass a reference to that object. Also DNConf need not keep a reference to the dn. I think you can just revert all changes to this file.
|
https://issues.apache.org/jira/browse/HDFS-9895 has been fixed. Closing. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…operator APIs. : Delay the creation of SinkFunction for output streams. : Move StreamSpec from a public API to an internal class. Removed the MessageEnvelope and OutputStream interfaces from public operator APIs. Moved the creation of SinkFunction for output streams to SinkOperatorSpec. Moved StreamSpec from a public API to an internal class. Additionally, 1. Removed references to StreamGraph in OperatorSpecs. It was being used to getNextOpId(). MessageStreamsImpl now gets the ID and gives it to OperatorSpecs itself. 2. Updated and cleaned up the StreamGraphBuilder examples. 3. Renamed SinkOperatorSpec to OutputOperatorSpec since its used by sink, sendTo and partitionBy. nickpan47 and xinyuiscool, please take a look. Author: Prateek Maheshwari <pmaheshw@linkedin.com> Reviewers: Jagadish <jagadish@apache.org>, Yi Pan <nickpan47@gmail.com> Closes apache#92 from prateekm/message-envelope-removal
This was referenced Apr 2, 2020
This was referenced Apr 11, 2020
This was referenced May 14, 2020
This was referenced May 22, 2020
This was referenced Jun 2, 2020
This was referenced Jun 18, 2020
Closed
This was referenced Jul 6, 2020
This was referenced Jul 18, 2020
Merged
saxenapranav
pushed a commit
to saxenapranav/hadoop
that referenced
this pull request
Aug 11, 2023
Fixing Behavior of FS APIs on Root Operation
NyteKnight
pushed a commit
to NyteKnight/hadoop
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please kindly review the patch v001, see also https://issues.apache.org/jira/browse/HDFS-9895.