HADOOP-16922. ABFS: Change User-Agent header #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Driver test results using accounts in Central India Account with HNS Support Account without HNS support |
DadanielZ
reviewed
Apr 3, 2020
...-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsClient.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
changed the title
steveloughran
requested changes
Apr 6, 2020
| @@ -679,32 +679,60 @@ public AuthType getAuthType() { | |||
|
|
|||
| @VisibleForTesting | |||
| String initializeUserAgent(final AbfsConfiguration abfsConfiguration, | |||
| final String sslProviderName) { | |||
| final String sslProviderName) { | |||
There was a problem hiding this comment.
if you pulled this out somewhere or made static you could have a unit test which would validate some of this
There was a problem hiding this comment.
There are test cases written to validate this as this method is package protected and with the @VisibleForTesting.
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("(JavaJRE "); | ||
|
|
There was a problem hiding this comment.
can we have org.apache.hadoop.util.VersionInfo,getVersion() in there too? Lets people pin the blame on the logs
There was a problem hiding this comment.
CLIENT_VERSION includes org.apache.hadoop.util.VersionInfo,getVersion()
bilaharith
changed the title
|
Driver test results using accounts in Central India Account with HNS Support Account without HNS support |
|
🎊 +1 overall
This message was automatically generated. |
DadanielZ
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
LGTM, +1
@steveloughran do you have pending request for changes?
|
@DadanielZ I'm happy if you are. |
|
At present the User-Agent header would look like: With this PR it would be: |
steveloughran
changed the title
arjun4084346
pushed a commit
to arjun4084346/hadoop
that referenced
this pull request
Apr 11, 2022
Contributed by Bilahari T H. (cherry picked from commit 264e49c)
zhangxiping1
pushed a commit
to zhangxiping1/hadoop
that referenced
this pull request
Dec 13, 2022
Contributed by Bilahari T H.
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
Contributed by Bilahari T H. Conflicts: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java Change-Id: Icc968be7234dcf93f352280c056d645a9439c459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-16922. Changing User-Agent header.
At present the User-Agent header would look like:
Azure Blob FS/3.4.0-SNAPSHOT (JavaJRE 1.8.0_241; Linux 5.3.0-46-generic; SunJSSE-1.8) MSFT
With this PR it would be:
APN/1.0 Azure Blob FS/3.4.0-SNAPSHOT (OracleCorporation JavaJRE 1.8.0_241; Linux 5.3.0-46-generic/amd64; SunJSSE-1.8; UNKNOWN/UNKNOWN) MSFT