Skip to content

HDFS-15462. Add fs.viewfs.overload.scheme.target.ofs.impl to core-default.xml #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

HDFS-15462. Add fs.viewfs.overload.scheme.target.ofs.impl to core-default.xml #2131

merged 1 commit into from
Jul 9, 2020

Conversation

smengcl
Copy link
Contributor

@smengcl smengcl commented Jul 9, 2020

https://issues.apache.org/jira/browse/HDFS-15462

HDFS-15394 added existing FS implementations in core-default.xml except ofs. Let's add ofs to core-default as well.

@smengcl
Add fs.viewfs.overload.scheme.target.ofs.impl
eed2df9 
Change-Id: Ic63694d659bf99b03e11bf8f616fc494448b5b5a
@smengcl smengcl added the HDFS label Jul 9, 2020
@smengcl smengcl requested a review from umamaheswararao July 9, 2020 04:37
@smengcl smengcl self-assigned this Jul 9, 2020
bharatviswa504
bharatviswa504 reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@umamaheswararao
Copy link
Contributor

Thanks @smengcl for reporting it. Yes, when we added other fss in config, ofs branch was not merged. Thanks for the fix. All good.
Consider @bharatviswa504 vote, go ahead merging. Thanks @bharatviswa504 for review.
Pending jenkins.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 23m 32s trunk passed
+1 💚 compile 24m 23s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 22m 28s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 0m 50s trunk passed
+1 💚 mvnsite 1m 42s trunk passed
+1 💚 shadedclient 20m 23s branch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 45s hadoop-common in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 1m 11s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 3m 3s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 0s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 59s the patch passed
+1 💚 compile 25m 56s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 javac 25m 56s the patch passed
+1 💚 compile 21m 45s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 21m 45s the patch passed
+1 💚 checkstyle 0m 55s the patch passed
+1 💚 mvnsite 1m 43s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 shadedclient 17m 1s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 49s hadoop-common in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
+1 💚 javadoc 1m 8s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 3m 1s the patch passed
_ Other Tests _
+1 💚 unit 11m 13s hadoop-common in the patch passed.
+1 💚 asflicense 0m 55s The patch does not generate ASF License warnings.
187m 2s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2131/1/artifact/out/Dockerfile
GITHUB PR #2131
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname Linux 57a124b357e9 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5b1ed21
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2131/1/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-2131/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2131/1/testReport/
Max. process+thread count 2989 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2131/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@smengcl
Copy link
Contributor Author

smengcl commented Jul 9, 2020

Thanks @umamaheswararao and @bharatviswa504 for reviewing this. javadoc -1's are from unrelated profobuf warnings.

Will merge shortly.

@smengcl smengcl merged commit 0e694b2 into apache:trunk Jul 9, 2020
umamaheswararao pushed a commit that referenced this pull request Jul 9, 2020
@smengcl @umamaheswararao
HDFS-15462. Add fs.viewfs.overload.scheme.target.ofs.impl to core-def…
3589340 
…ault.xml (#2131)

(cherry picked from commit 0e694b2)
umamaheswararao pushed a commit that referenced this pull request Jul 9, 2020
@smengcl @umamaheswararao
HDFS-15462. Add fs.viewfs.overload.scheme.target.ofs.impl to core-def…
0bd0cb1 
…ault.xml (#2131)

(cherry picked from commit 0e694b2)
umamaheswararao pushed a commit that referenced this pull request Jul 9, 2020
@smengcl @umamaheswararao
HDFS-15462. Add fs.viewfs.overload.scheme.target.ofs.impl to core-def…
47df224 
…ault.xml (#2131)

(cherry picked from commit 0e694b2)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@smengcl
CDPD-15034. HDFS-15462. Add fs.viewfs.overload.scheme.target.ofs.impl…
8dbfa64 
… to core-default.xml (apache#2131)

(cherry picked from commit 0e694b2)

Change-Id: I8b2616cc50202957944b747e76a19ac6adb02e58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatviswa504 bharatviswa504 bharatviswa504 left review comments

@umamaheswararao umamaheswararao umamaheswararao approved these changes

Assignees

@smengcl smengcl

Labels
HDFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smengcl @umamaheswararao @hadoop-yetus @bharatviswa504