HDFS-15480. Ordered snapshot deletion: record snapshot deletion in XAttr #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
mukul1987
requested changes
Jul 21, 2020
There was a problem hiding this comment.
Thanks for updating the patch @bshashikant. The latest patch looks really good to me.
testSnapshotXattrPersistence can we also have a version where we do a saveNamespace before restart ? This is to verify that the attr is stored in FSImage correctly. ?
...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java
Outdated
Show resolved
Hide resolved
mukul1987
approved these changes
Jul 21, 2020
szetszwo
requested changes
Jul 21, 2020
...roject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java
Outdated
Show resolved
Hide resolved
...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java
Outdated
Show resolved
Hide resolved
...fs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
mukul1987
reviewed
Jul 22, 2020
...p-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestOrderedSnapshotDeletion.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
szetszwo
requested changes
Jul 22, 2020
There was a problem hiding this comment.
@bshashikant , thanks for the update. Some minor comments inlined.
BTW, do you know why hadoop-yetus reporting "Docker failed"? We may try posting a patch on the JIRA if yetus does not work in pull requests.
| @@ -366,6 +366,7 @@ public void write(DataOutput out) throws IOException { | |||
| "security.hdfs.unreadable.by.superuser"; | |||
| String XATTR_ERASURECODING_POLICY = | |||
| "system.hdfs.erasurecoding.policy"; | |||
| String SNAPSHOT_XATTR_NAME = "system.hdfs.snapshot"; | |||
There was a problem hiding this comment.
The xattr name should contain "deleted". How about "system.hdfs.snapshot.deleted"?
| @@ -326,6 +327,12 @@ static INode unprotectedSetXAttrs( | |||
| throw new IOException("Can only set '" + | |||
| SECURITY_XATTR_UNREADABLE_BY_SUPERUSER + "' on a file."); | |||
| } | |||
|
|
|||
| if (xaName.equals(SNAPSHOT_XATTR_NAME) && !(inode.isDirectory() && | |||
There was a problem hiding this comment.
Let's check "!(inode instanceof of Snapshot.Root)" instead of "!(inode.isDirectory() && inode.getParent().isSnapshottable())?
| @@ -5119,7 +5119,6 @@ | |||
| for storing directory snapshot diffs. By default, value is set to 10. | |||
| </description> | |||
| </property> | |||
|
|
|||
There was a problem hiding this comment.
We should leave hdfs-default.xml untouched since we are not changing anything.
|
💔 -1 overall
This message was automatically generated. |
|
Yetus was able to run over the 002 patch posted on the JIRA. +1 on the 002 patch. |
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…ttr (apache#2163) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java Change-Id: I049a3b94ab1492a3bf3fdc25cd4320984ffa1cec (cherry picked from commit 88e910e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://issues.apache.org/jira/browse/HDFS-15480