-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix Helm Chart RC Staging Documentation Links #55677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jscheffl
merged 2 commits into
apache:main
from
HsiuChuanHsu:fix/helm-chart-rc-staging-doc-links
Nov 2, 2025
Merged
Fix Helm Chart RC Staging Documentation Links #55677
jscheffl
merged 2 commits into
apache:main
from
HsiuChuanHsu:fix/helm-chart-rc-staging-doc-links
Nov 2, 2025
+130
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4dacdc to
e31f408
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
e31f408 to
ff2acee
Compare
Replace production documentation links (airflow.apache.org) with staging links (airflow.staged.apache.org) for Helm Chart release candidates. - Add RC version detection (rc, alpha, beta releases) - Modify prepare-helm-chart-tarball and prepare-helm-chart-package commands - Implement safe backup/restore for Chart.yaml modifications - Add --version-suffix option to helm chart package command
- Simplify RC version detection logic - Add RC version test case to helm-tests.yml workflow - Update documentation to include --version-suffix parameter usage
ff2acee to
36fa3b4
Compare
jscheffl
approved these changes
Nov 2, 2025
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Contributor
Author
|
Thanks for the reivew! |
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* fix Replace Helm Chart RC docs links with staging URLs Replace production documentation links (airflow.apache.org) with staging links (airflow.staged.apache.org) for Helm Chart release candidates. - Add RC version detection (rc, alpha, beta releases) - Modify prepare-helm-chart-tarball and prepare-helm-chart-package commands - Implement safe backup/restore for Chart.yaml modifications - Add --version-suffix option to helm chart package command * Improve Helm chart RC version handling and testing - Simplify RC version detection logic - Add RC version test case to helm-tests.yml workflow - Update documentation to include --version-suffix parameter usage
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Feb 1, 2026
We do _not_ want the staging links in our RC assets, since we copy those assets over as-is when the vote has passed. PR apache#55677 incorrectly assumed there were separate production and RC builds.
1 task
jedcunningham
added a commit
that referenced
this pull request
Feb 1, 2026
We do _not_ want the staging links in our RC assets, since we copy those assets over as-is when the vote has passed. PR #55677 incorrectly assumed there were separate production and RC builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes documentation links in the Helm Chart Release Candidate (RC) versions to properly point to the staged documentation (https://airflow.staged.apache.org) instead of the stable documentation (https://airlfow.apache.org/).
Based on the guidance from @potiuk:
Changes introduced
Two functions in
release-managementhave been updated to replace the URLs dynamically when Helm Chart RC versions are released:prepare-helm-chart-tarballprepare-helm-chart-packageWith this change:
Closes: #50569
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.