Skip to content

Conversation

@HsiuChuanHsu
Copy link
Contributor

Description

This PR fixes documentation links in the Helm Chart Release Candidate (RC) versions to properly point to the staged documentation (https://airflow.staged.apache.org) instead of the stable documentation (https://airlfow.apache.org/).

Based on the guidance from @potiuk:

How it should be done - the links should be still "prod" - but they should be dynamically replaced with the staged build when .RC version of the chart is being prepared as release - so it should be part of the "breeze release-management" commands and code that is run to prepare the release, not committed to the repo.
Ref: #54493 (review)

Changes introduced

Two functions in release-management have been updated to replace the URLs dynamically when Helm Chart RC versions are released:

  1. prepare-helm-chart-tarball
  2. prepare-helm-chart-package

With this change:

  • Production builds will continue pointing to production documentation links.
  • RC builds will automatically use staging documentation links during the release preparation process.

Closes: #50569


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 31, 2025
@HsiuChuanHsu HsiuChuanHsu force-pushed the fix/helm-chart-rc-staging-doc-links branch from e31f408 to ff2acee Compare November 2, 2025 06:25
Replace production documentation links (airflow.apache.org) with staging links
(airflow.staged.apache.org) for Helm Chart release candidates.
- Add RC version detection (rc, alpha, beta releases)
- Modify prepare-helm-chart-tarball and prepare-helm-chart-package commands
- Implement safe backup/restore for Chart.yaml modifications
- Add --version-suffix option to helm chart package command
- Simplify RC version detection logic
- Add RC version test case to helm-tests.yml workflow
- Update documentation to include --version-suffix parameter usage
@jscheffl jscheffl force-pushed the fix/helm-chart-rc-staging-doc-links branch from ff2acee to 36fa3b4 Compare November 2, 2025 12:42
@eladkal eladkal removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 2, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jscheffl jscheffl merged commit 6018768 into apache:main Nov 2, 2025
116 checks passed
@HsiuChuanHsu
Copy link
Contributor Author

Thanks for the reivew!

@HsiuChuanHsu HsiuChuanHsu deleted the fix/helm-chart-rc-staging-doc-links branch November 3, 2025 14:01
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
* fix Replace Helm Chart RC docs links with staging URLs

Replace production documentation links (airflow.apache.org) with staging links
(airflow.staged.apache.org) for Helm Chart release candidates.
- Add RC version detection (rc, alpha, beta releases)
- Modify prepare-helm-chart-tarball and prepare-helm-chart-package commands
- Implement safe backup/restore for Chart.yaml modifications
- Add --version-suffix option to helm chart package command

* Improve Helm chart RC version handling and testing
- Simplify RC version detection logic
- Add RC version test case to helm-tests.yml workflow
- Update documentation to include --version-suffix parameter usage
jedcunningham added a commit to astronomer/airflow that referenced this pull request Feb 1, 2026
We do _not_ want the staging links in our RC assets, since we copy those
assets over as-is when the vote has passed.

PR apache#55677 incorrectly assumed there were separate production and RC
builds.
jedcunningham added a commit that referenced this pull request Feb 1, 2026
We do _not_ want the staging links in our RC assets, since we copy those
assets over as-is when the vote has passed.

PR #55677 incorrectly assumed there were separate production and RC
builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-release candidates of Helm Chart should have staging doc links

3 participants