Fix links in helm chart package #61303
Conversation
We do _not_ want the staging links in our RC assets, since we copy those assets over as-is when the vote has passed. PR apache#55677 incorrectly assumed there were separate production and RC builds.
jedcunningham
requested review from
amoghrajesh,
ashb,
bugraoz93,
ephraimbuddy,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker f08b40c v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Turns out the VERSION_SUFFIX env var is used as the default for the --version-suffix flag, and we do not want it set when we are preparing the package. More permanent fix coming soon, but this unblocks PMC verification for 1.19.0rc2. Related: apache#61303
Turns out the VERSION_SUFFIX env var is used as the default for the --version-suffix flag, and we do not want it set when we are preparing the package. More permanent fix coming soon, but this unblocks PMC verification for 1.19.0rc2. Related: #61303
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Sorry, needed to get to bed early yesterday, thanks for taking care!
Yeah as in your email in devlist I also thought as changed here is "right". Looking forward for RC2 whereas other than documentation links I assume no surprises.
|
This was the first thing I suspected too, but wasn't fully sure if the release process is different than others on that point. Great to know! Thanks Jed! PS: Even we don't need backport since we are releasing from main but would be good to align the docs just in case on the fixed part. Will check it out if no one has disagreement on that. Of course you can raise on PR too |
jscheffl
removed
the
backport-to-v3-1-test
5 participants
We do not want the staging links in our RC assets, since we copy those assets over as-is when the vote has passed.
PR #55677 incorrectly assumed there were separate production and RC builds.
Was generative AI tooling used to co-author this PR?
Generated-by: Cursor CLI (Claude Opus 4.5)