Skip to content

Conversation

@prdai
Copy link
Contributor

@prdai prdai commented Aug 14, 2025

This PR updates the documentation links in Chart.yaml and values.yaml for Helm Chart pre-release candidates.
Previously, these links pointed to the production docs at https://airflow.apache.org, which is inconsistent with other pre-release artifacts (e.g., PyPI packages) that reference staged docs.

Changes in this PR:

related: #50569

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Aug 14, 2025
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea - how do you distinguish whether it's pre-release or not? We cannot really commit the code for pre-release / staging docs because we would have to somehow remember to bring them back to PROD - that's very, very brittle.

How it should be done - the links should be still "prod" - but they should be dynamically replaced with the staged build when .RC version of the chart is being prepared as release - so it should be part of the "breeze release-management" commands and code that is run to prepare the release, not committed to the repo

@HsiuChuanHsu
Copy link
Contributor

HsiuChuanHsu commented Sep 14, 2025

Hi @Programmer-RD-AI,
I noticed this PR has been not updated for a while now.
Just wanted to check in and see if you're still working on it. If not, I'd be happy to take over.

Let me know what you think!

@prdai
Copy link
Contributor Author

prdai commented Sep 14, 2025

hi @HsiuChuanHsu please feel free to take over, i have been unable to look into this since the initial pr, thanks :) i will close the pr so that you can start?

@prdai prdai closed this Sep 14, 2025
@HsiuChuanHsu
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants