Skip to content

[ENH] add informational tags back to estimator docs #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 17, 2025

Conversation

inclinedadarsh
Copy link
Contributor

Reference Issues/PRs

Fixes #2490

What does this implement/fix? Explain your changes.

Add all the information back in the docs in the form of tags. Please checkout #2490 for more infromation.

Does your contribution introduce a new dependency? If yes, which one?

Nope.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added anomaly detection Anomaly detection package enhancement New feature, improvement request or other non-bug code enhancement labels Mar 18, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#6F6E8D}{\textsf{anomaly detection}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@inclinedadarsh
Copy link
Contributor Author

Hello @MatthewMiddlehurst @SebastianSchmidl

I have included the tags as suggested in #2490 (comment)

I tried running the tests; however, the tests are failing because of the tags I add, and I don't really understand why.

One reason I believe is that I need to add all the tags in all the models, I'm not sure though. If this is the case, then the tag output_data_format is of string type, I don't understand what should I add in that field in other models.

Some help on this is appreciated.

Thank you!

@MatthewMiddlehurst
Copy link
Member

if you set "class" to all estimators then it will expect it for all estimators

@inclinedadarsh
Copy link
Contributor Author

Hey, I can't seem to figure out what value should be given for the class key for it to only check for anomaly detection modules.

I tried using anomaly_detector but tests fail on that one. I tried finding the file where all the values for the class key are mentioned but couldn't find it.

Can you help me figure out what will be used for the class key?

@SebastianSchmidl
Copy link
Member

It should be "anomaly-detector"

@inclinedadarsh inclinedadarsh marked this pull request as ready for review April 25, 2025 15:12
@inclinedadarsh
Copy link
Contributor Author

Hey @SebastianSchmidl, the only two tests failing right now are the new tags not added for the ROCKAD class under whole_series submodule.

At the time of creation of this issue, that class didn't exist so the values for output_data_format, learning_type:unsupervised and learning_type:semi_supervised aren't documented.

Could you let me know the values of these tags for the ROCKAD class, or let me know how I can find these values?

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the looks of things semi-supervised and scores?

@SebastianSchmidl
Copy link
Member

By the looks of things semi-supervised and scores?

Yes.

@MatthewMiddlehurst
Copy link
Member

Hi, we are planning (another) refactor for anomaly detection which is likely to make this more complicated. I would prefer to get this in first, so may push some changes myself.

@MatthewMiddlehurst
Copy link
Member

Should be ready for review.

@SebastianSchmidl SebastianSchmidl merged commit 02ae7c6 into aeon-toolkit:main May 17, 2025
16 checks passed
TinaJin0228 pushed a commit to TinaJin0228/aeon that referenced this pull request May 23, 2025
* feat: add new tags information for anomaly detection

* feat: add tag information in given anomaly modles

* fix: add new anomaly detector tags in mock anomaly detector class

* fix: use anomaly-detector instead of estimator for new tags

* update and add basic testing

* fixes

---------

Co-authored-by: MatthewMiddlehurst <pfm15hbu@gmail.com>
MatthewMiddlehurst added a commit that referenced this pull request May 23, 2025
* add difference transformer to series transformations

* add myself to .all-contributorsrc

* small modification

* modify according to reviews

* [ENH] add informational tags back to estimator docs (#2652)

* feat: add new tags information for anomaly detection

* feat: add tag information in given anomaly modles

* fix: add new anomaly detector tags in mock anomaly detector class

* fix: use anomaly-detector instead of estimator for new tags

* update and add basic testing

* fixes

---------

Co-authored-by: MatthewMiddlehurst <pfm15hbu@gmail.com>

* [DOC] Documentation improvement of BaseSeriesEstimator and BaseAeonEstimator (#2612)

* Added the docs for base series and base classes

* Updated documentation for base classes

---------

Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>

* [ENH] HydraTransformer Output changed (#2656)

* output type added

* hydra wflow modified

* hydra test file added

* pr_pytest reverted

* soft dep check added

* soft dep corrected

* docstring corrected, enhanced test cases

* [DOC] Improved Hidalgo Segmentation Notebook (#2616)

* Improved Hidalgo Segmentation Notebook

* Updated hidalgo notebook

---------

Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>

* new devs and workflow consolidation (#2797)

* all branches (#2809)

* Automated `pre-commit` hook update (#2820)

Co-authored-by: TonyBagnall <9594042+TonyBagnall@users.noreply.github.com>

* [MNT] Bump crs-k/stale-branches in the github-actions group (#2821)

Bumps the github-actions group with 1 update: [crs-k/stale-branches](https://github.com/crs-k/stale-branches).


Updates `crs-k/stale-branches` from 7.0.1 to 8.1.1
- [Release notes](https://github.com/crs-k/stale-branches/releases)
- [Commits](crs-k/stale-branches@v7.0.1...v8.1.1)

---
updated-dependencies:
- dependency-name: crs-k/stale-branches
  dependency-version: 8.1.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: indexing in kdtw (#2826)

* [ENH] Added test cases for feature based clustering (#2690)

* Added test cases for feature based clustering

* Automatic `pre-commit` fixes

* added docstring

* Automatic `pre-commit` fixes

* added .

* added .

* updated tsfresh

* Automatic `pre-commit` fixes

* added pytest _check_soft_dependencies for tsfresh

* Automatic `pre-commit` fixes

* added more testing

* Automatic `pre-commit` fixes

* added docs

* added docs

* added pytest

* Automatic `pre-commit` fixes

* improved docs

* Automatic `pre-commit` fixes

* improved test cases

* changes made as requested by moderators

* changes made as requested by moderators

* Automatic `pre-commit` fixes

* changed "percentiles" to "quantiles"

---------

Co-authored-by: Ramana-Raja <ramanarajakesavaraja@gamil.com>
Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>
Co-authored-by: Tony Bagnall <a.j.bagnall@soton.ac.uk>

* [DOC] Fix inconsistent double backticks in updated  similarity_search module docstrings (#2618)

* delete some descriptions

* modification to _maintainer_

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>
Co-authored-by: Tony Bagnall <a.j.bagnall@soton.ac.uk>
Co-authored-by: Adarsh Dubey <dubeyadarshmain@gmail.com>
Co-authored-by: Kevin Shah <161136814+kevinzb56@users.noreply.github.com>
Co-authored-by: Balgopal Moharana <99070111+lucifer4073@users.noreply.github.com>
Co-authored-by: Kavya Rambhia <161142013+kavya-r30@users.noreply.github.com>
Co-authored-by: aeon-actions-bot[bot] <148872591+aeon-actions-bot[bot]@users.noreply.github.com>
Co-authored-by: TonyBagnall <9594042+TonyBagnall@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Schmidl <10573700+SebastianSchmidl@users.noreply.github.com>
Co-authored-by: Ramana Raja <83065061+Ramana-Raja@users.noreply.github.com>
Co-authored-by: Ramana-Raja <ramanarajakesavaraja@gamil.com>
Co-authored-by: Ciph3r <142653450+adityagh006@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly detection Anomaly detection package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Anomaly detection module: Add informational tags back to estimator docs
3 participants