-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Improved Hidalgo Segmentation Notebook #2616
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
@@ -2,46 +2,167 @@ | |||
"cells": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep this notebook I think we need a bit more information on what Hidalgo Segmentation is and why you would use it. Otherwise may be best to just remove.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that providing more information on what Hidalgo Segmentation is and why it would be used is important, I have now added a detailed overview, including the algorithm's function, applications, and benefits and references
@@ -2,46 +2,167 @@ | |||
"cells": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have functions in the visualisation module that may be useful for this. For both plotting series and output. If those don't work thats ok but best to try.
Reply via ReviewNB
@@ -2,46 +2,167 @@ | |||
"cells": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, the plot displayed the three channels offset by different values to show changes in segmentation of the same series. Now, I have used plot_series and plot_series_with_change_points from visualisation module to visualize the change points and input
Reference Issues/PRs
Fixes #2615
What does this implement/fix? Explain your changes.
Improves Hidalgo Segmentation Notebook
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access