Skip to content

[DOC] Fix inconsistent double backticks in similarity_search module (#809) #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

adityagh006
Copy link
Contributor

This PR addresses issue #809 by standardizing the use of double backticks (``) for inline code references in the similarity_search module. Previously, some docstrings inconsistently used single backticks (`), which rendered text as italics instead of formatted code.

Changes made:
Replaced inconsistent single backticks with double backticks for inline code references.
Ensured uniform formatting across the following files:
aeon/similarity_search/base.py
aeon/similarity_search/distance_profiles/euclidean_distance_profile.py
aeon/similarity_search/distance_profiles/squared_distance_profile.py
aeon/similarity_search/matrix_profiles/stomp.py
aeon/similarity_search/query_search.py
aeon/similarity_search/series_search.py
Maintained readability and adherence to the Aeon documentation guidelines.
This update improves the clarity of API documentation and aligns with the preferred style for referring to code elements.

@adityagh006 adityagh006 requested a review from baraline as a code owner March 13, 2025 20:20
@aeon-actions-bot aeon-actions-bot bot added documentation Improvements or additions to documentation similarity search Similarity search package labels Mar 13, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#F3B9F8}{\textsf{documentation}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#006b75}{\textsf{similarity search}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@adityagh006 adityagh006 force-pushed the doc-fix-similarity-search branch from 3cd3b42 to a78512d Compare March 15, 2025 16:43
@adityagh006
Copy link
Contributor Author

Hi @baraline, it looks like tj-actions/changed-files@v45 couldn't be fetched, possibly due to a version issue. Updating it to v44 or v46 in .github/workflows/pre-commit.yml might help. Let me know how to proceed!

@baraline
Copy link
Member

Hi, I'd wait for #2473 to be in for this PR to go through, as it will rework the module completely. Regarding the precommit issue, this is something we'll fix as it is currently affecting other PRs

@adityagh006 adityagh006 force-pushed the doc-fix-similarity-search branch from 6650cf3 to a78512d Compare April 12, 2025 07:14
@adityagh006
Copy link
Contributor Author

Hi @baraline,

The changes in this PR address issue #809 by standardizing the use of double backticks for inline code references in the similarity_search module. I’ve replaced inconsistent single backticks with double backticks across the relevant files.

Since the CI checks have passed and the changes are ready for review, could you kindly review and approve the PR when possible?

@MatthewMiddlehurst
Copy link
Member

In-case this was not clear in the previous message, the vast majority of this code is due to be removed or significantly changed. We probably won't review this because its never going to see a release even if merged. I'll keep this open for now so its visible for GSoC purposes if that is relevant, but it will likely be closed.

@adityagh006
Copy link
Contributor Author

Thanks for the clarification, @MatthewMiddlehurst. I understand that the module is scheduled for major changes and that this PR may not be merged. I appreciate you keeping it open for visibility in the context of GSoC.

@baraline
Copy link
Member

Hi @adityagh006, do you intend to work on this again ? The PR updating the code have been merged.

@adityagh006
Copy link
Contributor Author

Yeah, sure! I’ll sync my branch with the latest changes and update the PR accordingly. Thanks for the heads-up!

@adityagh006
Copy link
Contributor Author

Hi @baraline,
I’m working on the similarity_search module and noticed the structure has changed a lot. Could you confirm which files need to be updated for the tick inconsistency task?

@baraline
Copy link
Member

Hi, i think you can check most files, that are not tests, you may find some work to do on those. Dont have any specifics sorry

@adityagh006 adityagh006 force-pushed the doc-fix-similarity-search branch from e3192b0 to e01dbde Compare May 13, 2025 09:02
@adityagh006
Copy link
Contributor Author

Hi @baraline,
I've updated the PR to reflect the latest changes in the similarity_search module and standardized the inconsistent backticks as discussed. All checks have passed successfully. Kindly review when convenient. Thanks!

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lgtm

@baraline baraline merged commit 55188f9 into aeon-toolkit:main May 21, 2025
16 checks passed
TinaJin0228 pushed a commit to TinaJin0228/aeon that referenced this pull request May 23, 2025
MatthewMiddlehurst added a commit that referenced this pull request May 23, 2025
* add difference transformer to series transformations

* add myself to .all-contributorsrc

* small modification

* modify according to reviews

* [ENH] add informational tags back to estimator docs (#2652)

* feat: add new tags information for anomaly detection

* feat: add tag information in given anomaly modles

* fix: add new anomaly detector tags in mock anomaly detector class

* fix: use anomaly-detector instead of estimator for new tags

* update and add basic testing

* fixes

---------

Co-authored-by: MatthewMiddlehurst <pfm15hbu@gmail.com>

* [DOC] Documentation improvement of BaseSeriesEstimator and BaseAeonEstimator (#2612)

* Added the docs for base series and base classes

* Updated documentation for base classes

---------

Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>

* [ENH] HydraTransformer Output changed (#2656)

* output type added

* hydra wflow modified

* hydra test file added

* pr_pytest reverted

* soft dep check added

* soft dep corrected

* docstring corrected, enhanced test cases

* [DOC] Improved Hidalgo Segmentation Notebook (#2616)

* Improved Hidalgo Segmentation Notebook

* Updated hidalgo notebook

---------

Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>

* new devs and workflow consolidation (#2797)

* all branches (#2809)

* Automated `pre-commit` hook update (#2820)

Co-authored-by: TonyBagnall <9594042+TonyBagnall@users.noreply.github.com>

* [MNT] Bump crs-k/stale-branches in the github-actions group (#2821)

Bumps the github-actions group with 1 update: [crs-k/stale-branches](https://github.com/crs-k/stale-branches).


Updates `crs-k/stale-branches` from 7.0.1 to 8.1.1
- [Release notes](https://github.com/crs-k/stale-branches/releases)
- [Commits](crs-k/stale-branches@v7.0.1...v8.1.1)

---
updated-dependencies:
- dependency-name: crs-k/stale-branches
  dependency-version: 8.1.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: indexing in kdtw (#2826)

* [ENH] Added test cases for feature based clustering (#2690)

* Added test cases for feature based clustering

* Automatic `pre-commit` fixes

* added docstring

* Automatic `pre-commit` fixes

* added .

* added .

* updated tsfresh

* Automatic `pre-commit` fixes

* added pytest _check_soft_dependencies for tsfresh

* Automatic `pre-commit` fixes

* added more testing

* Automatic `pre-commit` fixes

* added docs

* added docs

* added pytest

* Automatic `pre-commit` fixes

* improved docs

* Automatic `pre-commit` fixes

* improved test cases

* changes made as requested by moderators

* changes made as requested by moderators

* Automatic `pre-commit` fixes

* changed "percentiles" to "quantiles"

---------

Co-authored-by: Ramana-Raja <ramanarajakesavaraja@gamil.com>
Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>
Co-authored-by: Tony Bagnall <a.j.bagnall@soton.ac.uk>

* [DOC] Fix inconsistent double backticks in updated  similarity_search module docstrings (#2618)

* delete some descriptions

* modification to _maintainer_

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>
Co-authored-by: Tony Bagnall <a.j.bagnall@soton.ac.uk>
Co-authored-by: Adarsh Dubey <dubeyadarshmain@gmail.com>
Co-authored-by: Kevin Shah <161136814+kevinzb56@users.noreply.github.com>
Co-authored-by: Balgopal Moharana <99070111+lucifer4073@users.noreply.github.com>
Co-authored-by: Kavya Rambhia <161142013+kavya-r30@users.noreply.github.com>
Co-authored-by: aeon-actions-bot[bot] <148872591+aeon-actions-bot[bot]@users.noreply.github.com>
Co-authored-by: TonyBagnall <9594042+TonyBagnall@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Schmidl <10573700+SebastianSchmidl@users.noreply.github.com>
Co-authored-by: Ramana Raja <83065061+Ramana-Raja@users.noreply.github.com>
Co-authored-by: Ramana-Raja <ramanarajakesavaraja@gamil.com>
Co-authored-by: Ciph3r <142653450+adityagh006@users.noreply.github.com>
@adityagh006 adityagh006 deleted the doc-fix-similarity-search branch May 26, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation similarity search Similarity search package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants