-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Documentation improvement of BaseSeriesEstimator and BaseAeonEstimator #2612
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
Please refrain from continually opening and closing PRs, just push changes to your branch. |
@MatthewMiddlehurst I have filled out the PR template, but some tests are still failing. I followed the development guide and retried multiple times, but a few tests continue to fail. Could you provide any guidance on resolving this? |
These were just sporadic failures, you only changed docs so its not related to your PR. Please use a consistent style with other classes, #2516 is cleaner IMO. |
@MatthewMiddlehurst I'm getting this message printed on the terminal
aeon/base/_base_series.py:10:89: E501 line too long (93 > 88 characters) Is it because of the length? I tried to shorten it by removing whitespaces but still the error persists |
yes lines can only be 88 characters in length |
@MatthewMiddlehurst Updated the docs! |
Reference Issues/PRs
solves #2509
What does this implement/fix? Explain your changes.
This PR adds comprehensive documentation for the BaseSeriesEstimator and BaseAeonEstimator class in the aeon library. The documentation follows the established format used for other base classes (e.g., BaseClassifier) and includes:
A clear description of the class's purpose and functionality.
A list of defining methods, grouped into logical categories (preprocessing, input checking, input conversion, and shape checking).
Inherited inspection methods and state attributes.
Additional context about the class's role in the library.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access