Adding a Save All menu item under File #1208
Conversation
| @@ -429,6 +429,14 @@ define(function (require, exports, module) { | |||
| } | |||
|
|
|||
| /** | |||
| * Saves all the unsaved files. | |||
| * @param {?{doc: Document}} commandData Not used in this function. | |||
There was a problem hiding this comment.
Please remove the unused argument
|
Also: would you be willing to submit a squashed pull request? We don't have any hard and fast rules on this yet, but 5 commits for a small diff like this feels a little high... so if it's not too much trouble, it'd be nice to squash it down to just 1. |
ghost
assigned 
Updated getModeFromFileExtensions to let cfm and cfc files use the html editor. This will make any ColdFusion developers experience with brackets much much better. Update master Update About dialog sprint number Update _shouldShowInTree to only hide specified hidden files. Solution for adobe#1133 Replace $.isArray with Array.isArray Adding comment for the handleFileSaveAll function Edited the comment Adding different shortcuts for Mac and Win
|
I've squashed them all and have pushed it. I'm still learning git and am not sure if I've done everything right. If there's something wrong, please let me know. |
|
Sorry for the delayed response -- I should have mentioned that we were on break all last week. Just a couple more nits -- see comments in the diff. |
| @@ -429,6 +429,14 @@ define(function (require, exports, module) { | |||
| } | |||
|
|
|||
| /** | |||
| * Saves all the unsaved files. | |||
| * @param None | |||
There was a problem hiding this comment.
No need to explicitly say this -- just leave off the @param line entirely.
|
@srinarasi -- if you have a chance to address those last three nits, then we can merge this right away! |
|
Sorry about the delay. I'll try to fix them today. |
|
No worries -- whenever you have time |
|
@srinarasi: we decided to just merge this as-is, and I'll commit those last cleanups on our end (along with the shortcut change proposed by @RaymondLim). Thanks for contributing! |
Add a Save All command (implementation already exists, just exposing it in the UI now)
This is a follow-up to original pull request #1208, which has already been merged. See comments there for discussion of these changes (particularly the shortcut debate).
It's a very simple change to add an option to save all the unsaved files. I'm just calling saveAll() from my handler.