Show hidden ".htaccess" files #1133
Conversation
|
Hi Tucker--good point! I think we're primarily hiding dot files to avoid including things like the ".git" folder in a repo, but it makes sense that you should be able to edit ordinary dot files. I suspect we'll want to generalize this beyond .htaccess specifically, though. We might want to have the notion of an exclusion list for the file tree, and add SCC folders like .svn/ and .git/ to the list by default. |
|
@njx Sounds like a good idea. |
|
I always feel most comfortable with a combination of exclusion and inclusion, though it has to be clear which is stronger. You might would stick with "in order of definition" in that case. |
ghost
assigned 
|
If the original premise was to hide things such as the default .DS_Store and Thumbs.db in addition to the generic .git and .svn folders, couldn't these be added to a specific exclusion list, and then show all other hidden files? For example, function _shouldShowInTree(entry) {
return [".git", ".svn", ".DS_Store", "Thumbs.db"].indexOf(entry.name) === -1;
} |
|
Yup, I think we might want to start there. |
|
Is there anything else that needs to be added to that initial block list? And should I submit a new pull request with that change reflected? |
|
That seems like a good set to me. (CVS doesn't have any dotfiles, does it?) Submitting a new pull request would be a little cleaner in terms of numbers of commits, but it also seems ok to just push up a new change to this existing request since it's pretty small. |
Updated getModeFromFileExtensions to let cfm and cfc files use the html editor. This will make any ColdFusion developers experience with brackets much much better. Update master Update About dialog sprint number Update _shouldShowInTree to only hide specified hidden files. Solution for adobe#1133 Replace $.isArray with Array.isArray Adding comment for the handleFileSaveAll function Edited the comment Adding different shortcuts for Mac and Win
* 'master' of github.com:adobe/brackets: Replace $.isArray with Array.isArray Update About dialog sprint number Update _shouldShowInTree to only hide specified hidden files. Solution for #1133 Update master Updated getModeFromFileExtensions to let cfm and cfc files use the html editor. This will make any ColdFusion developers experience with brackets much much better. Temporarily commenting out the expect call since we should be expecting it to be Cmd-9 on Mac, but I need to get the platform information to check it conditionally. Explicitly check for mac platform before using Cmd key for Ctrl in shortcuts temporary fix for #1111
Issue #98 addressed hidden files being shown, and as a result, filtered all files, excluding any that began with ".", making it very difficult to edit an .htaccess file.