Save all shortcut (Ctrl+Alt+s) disables some non-latin character input

[robertbak]

This is easy to notice if you're typing polish text, typing in "ś" (which is a commonly used character) requires pressing AltGr+s (Wiki about AltGr). But because AltGr key is treated as exactly the same as the combination Ctrl+Alt (WebKit Bugzilla discussion) pressing AltGr+s in Brackets causes "Save all" and no character output.

This can happen for any combination using Alt+Ctrl but the only other shortcut using this is the live preview (Alt+Ctrl+P), but (based only on the wiki article) it doesn't look like it causes any issues.

FIX:
I usually fix this by changing the shortcut to Ctrl+Shift+S which makes saving and saving all (Ctlr+S, Ctrl+Shift-S) similar to closing and closing all (Ctlr+W, Ctrl+Shift-W).

EDIT:
The shortcut was changed here: #1332

[njx]

Reviewed, marking move to backlog. This is a more general problem--lack of localized keyboard shortcuts--which we currently have on the backlog: https://trello.com/c/4k2yalBd. @adrocknaphobia, we might want to consider moving that further up on the backlog since this is a pretty bad problem for non-English users. Also, note that we're thinking of changing the way key bindings are registered as part of some upcoming extension API work (cc @dangoor), though I'm not sure that would make this easier by itself since it might not actually involve making bindings fully declarative.

[dangoor]

I have some opinions about keyboard shortcut handling and I think that whatever our API ends up looking like, we'll be need to be able to accommodate different keyboard needs/desires. We put a fair bit of thought into this on Bespin, because keyboard controls are so fundamental to an editor.

User-defined keyboard mappings had highest precedence, followed by mappings defined in extensions (so you could install an extension for vi bindings or an extension that fixes problems of the sort defined above), finally landing on whatever default happened to be put there when the command was created.

[gruehle]

There are a couple more keyboard shortcut stories:

• https://trello.com/c/3mZwu1DE - Keyboard Shortcuts stored in JSON files
• https://trello.com/c/BDLJdoQu - Keyboard Shortcut customization interface

Closing since the original bug is fixed, and there are at least 3 user stories covering additional functionality.

[niutech]

It's still not fixed! I cannot write a Polish letter ś (ctrl-alt-s) in Brackets sprint 26 and it saves all instead.

[dangoor]

@niutech Yes, I'm sorry we haven't gotten to a fix for this yet. We keep track of larger amounts of work in Trello cards which get scheduled into sprints. @gruehle's comment above includes links to the Trello cards that describe features which will ultimately fix this problem.

[niutech]

Ok, meanwhile I proposed a quick workaround in #4227.