[CLOSED] Adding a Save All menu item under File

[core-ai-bot]

Issue by srinarasi
Sunday Jul 01, 2012 at 12:08 GMT
Originally opened as adobe/brackets#1208

---

It's a very simple change to add an option to save all the unsaved files. I'm just calling saveAll() from my handler.

---

srinarasi included the following code: https://github.com/adobe/brackets/pull/1208/commits

[core-ai-bot]

Comment by peterflynn
Sunday Jul 01, 2012 at 23:54 GMT

---

Also: would you be willing to submit a squashed pull request? We don't have any hard and fast rules on this yet, but 5 commits for a small diff like this feels a little high... so if it's not too much trouble, it'd be nice to squash it down to just 1.

[core-ai-bot]

Comment by srinarasi
Monday Jul 02, 2012 at 17:52 GMT

---

I've squashed them all and have pushed it. I'm still learning git and am not sure if I've done everything right. If there's something wrong, please let me know.

[core-ai-bot]

Comment by peterflynn
Thursday Jul 12, 2012 at 18:43 GMT

---

Sorry for the delayed response -- I should have mentioned that we were on break all last week. Just a couple more nits -- see comments in the diff.

[core-ai-bot]

Comment by peterflynn
Tuesday Jul 17, 2012 at 08:41 GMT

---

@srinarasi -- if you have a chance to address those last three nits, then we can merge this right away!

[core-ai-bot]

Comment by srinarasi
Tuesday Jul 17, 2012 at 08:44 GMT

---

Sorry about the delay. I'll try to fix them today.

[core-ai-bot]

Comment by peterflynn
Tuesday Jul 17, 2012 at 18:56 GMT

---

No worries -- whenever you have time

[core-ai-bot]

Comment by peterflynn
Thursday Aug 02, 2012 at 20:31 GMT

---

@srinarasi: we decided to just merge this as-is, and I'll commit those last cleanups on our end (along with the shortcut change proposed by@RaymondLim). Thanks for contributing!