[CLOSED] removeMenuItem() API

[core-ai-bot]

Issue by peterflynn
Wednesday Nov 07, 2012 at 01:36 GMT
Originally opened as adobe/brackets#2072

---

Adds a new Menu API for removing existing menu items.

This is just polishing off an existing patch from@tpryan, #1193. The additional changes here are:

• Merge with master
• Fix unit tests to use unique command/menu ids since all of Menus-test now shares one window
• Some code cleanups in unit tests.
• Move tests to better spot in file.
• Small code/docs cleanups in removeMenuItem() -- mainly to address this comment

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/2072/commits

[core-ai-bot]

Comment by peterflynn
Wednesday Nov 07, 2012 at 01:39 GMT

---

I realized after the fact that relocating the unit tests within the file makes it hard to diff my changes vs. the original (to see the part that hasn't been code reviewed already).

But you can always copy-paste the two ranges from:
https://raw.github.com/tpryan/brackets/c13722f1a98de4e3fead35d572f28e1ffa5ea9e3/test/spec/Menu-test.js
https://raw.github.com/adobe/brackets/b76cc1e5d725df128bc6cd8ab16fb45856a8af96/test/spec/Menu-test.js
...and put them in temp files to diff them directly.

[core-ai-bot]

Comment by njx
Wednesday Nov 07, 2012 at 02:00 GMT

---

Looks fine, merging.