Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

removeMenuItem() API #2072

Merged
merged 16 commits into from
Nov 7, 2012
Merged

removeMenuItem() API #2072

merged 16 commits into from
Nov 7, 2012

Commits on Jun 29, 2012

  1. Configuration menu
    Copy the full SHA
    5048d29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5299d3f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    074cd9c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2012

  1. Fixing comment grammar mistake.

    Terrence Ryan committed Jul 11, 2012
    Configuration menu
    Copy the full SHA
    935a9b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2012

  1. Configuration menu
    Copy the full SHA
    9c5bc28 View commit details
    Browse the repository at this point in the history
  2. Added ability to accept commands as well as id's.

    Terrence Ryan committed Jul 13, 2012
    Configuration menu
    Copy the full SHA
    8d9ab5a View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2012

  1. Configuration menu
    Copy the full SHA
    25f0acb View commit details
    Browse the repository at this point in the history
  2. Fixed remove menu item to remove the parent <li> of the <a> link that…

    … contains it.
    Terrence Ryan committed Aug 2, 2012
    Configuration menu
    Copy the full SHA
    cfce664 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e22cf20 View commit details
    Browse the repository at this point in the history
  4. Removing Extraneous DIVIDER code

    Terrence Ryan committed Aug 2, 2012
    Configuration menu
    Copy the full SHA
    93a5dfc View commit details
    Browse the repository at this point in the history
  5. Adding test to verify that removing by command or commandID string wo…

    …uld work.
    Terrence Ryan committed Aug 2, 2012
    Configuration menu
    Copy the full SHA
    e4cdd4f View commit details
    Browse the repository at this point in the history
  6. Added exception handling for cases where someone throws junk into the…

    … function
    Terrence Ryan committed Aug 2, 2012
    Configuration menu
    Copy the full SHA
    fb5f19c View commit details
    Browse the repository at this point in the history
  7. Testing for proper handling of junk being thrown into the removeMenuI…

    …tem function.
    Terrence Ryan committed Aug 2, 2012
    Configuration menu
    Copy the full SHA
    5b01676 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c13722f View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2012

  1. Merge branch 'removeMenuItem' of https://github.com/tpryan/brackets i…

    …nto pflynn/remove-menuitem
    
    * 'removeMenuItem' of https://github.com/tpryan/brackets:
      Renaming variable to make it, you know, refer to what it actually is.
      Testing for proper handling of junk being thrown into the removeMenuItem function.
      Added exception handling for cases where someone throws junk into the function
      Adding test to verify that removing by command or commandID string would work.
      Removing Extraneous DIVIDER code
      Cleaning out some whitespace from my addition to the test.
      Fixed remove menu item to remove the parent <li> of the <a> link that contains it.
      Added ability to accept commands as well as id's.
      Fixing comment grammar mistake.
      Made changes to code in line with @peterflyn feedback here: #1193
      Checking in the addition of RemoveMenuItem.  Also made file pass jslint.
    
    Conflicts:
    	test/spec/Menu-test.js
    peterflynn committed Nov 7, 2012
    Configuration menu
    Copy the full SHA
    1488ebd View commit details
    Browse the repository at this point in the history
  2. Fix Menu.removeMenuItem() unit tests: update for new setup where all …

    …tests
    
    in spec share one window (use unique ids for everything).
    Code cleanup in removeMenuItem(): use existing utility method to compute
    menu item id. Plus some docs tweaks.
    peterflynn committed Nov 7, 2012
    Configuration menu
    Copy the full SHA
    b76cc1e View commit details
    Browse the repository at this point in the history