Skip to content

feat(svm): svm spoke binaries integration tests #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
May 27, 2025
Merged

feat(svm): svm spoke binaries integration tests #1048

merged 56 commits into from
May 27, 2025

Conversation

md0x
Copy link
Contributor

@md0x md0x commented May 16, 2025

Changes proposed in this PR:

  • Update the solana test validator to use the svm verified test binaries
  • Add close pda test

james-a-morris and others added 30 commits April 4, 2025 10:52
@james-a-morris
chore: create skeleton for svm spoke client (#965)
8b3ed44 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@pxrl
feat(svm): Initial SpokeUtils skeleton (#960)
6b1b65a
@melisaguevara
fix: epic branch lint (#972)
1b6939c
@pxrl
improve(Address): Support new EVM address from Base58 encoding
dff7f94 
SVM events emit addresses with base58-encoding. At least two addresses
emitted within an FundsDeposited or FilledRelay event will need to be
converted to a base16 EVM address. Make it easy by permitting the caller
of EvmAddress.from() to specify the encoding, defaulting to base16.
@pxrl
Add svm/base16 counterpart
60ecbce
@pxrl
lint
58f376c
@pxrl
Merge remote-tracking branch 'origin/master'
1a79e88
@pxrl
Add test
b8aedad
@pxrl
lint
eb9ae20
@pxrl
Merge remote-tracking branch 'origin/pxrl/base58EVMAddress' into epic…
fc4c167 
…/svm-client
@pxrl
chore: Unify svm w/ arch/svm (#977)
27ce8ec 
No functional change; only relocate so that all svm functionality is
localised to src/arch/svm.
@james-a-morris
refactor(sdk): transition SVM events client to use blocks instead of …
57d86cd 
…slots (#973)

Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@melisaguevara
feat(svmSpokeUtils): get fill deadline buffer implementation (#978)
06e400d
@bmzig
improve: allow SVM events client to take in non-spoke IDLs (#982)
c9ee25e 
Signed-off-by: bennett <bennett@umaproject.org>
@melisaguevara
improve(svmEventsClient): enable pda events querying (#989)
3e20d7e
@james-a-morris
feat: create svm spoke _update (#976)
c5efe4a 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@james-a-morris
improve: add tests for SVM (#1007)
4f9b54f 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
@melisaguevara
feat(SvmSpokePoolClient): relayFillStatus and fillStatusArray impleme…
eec28b8 
…ntation (#990)
@md0x
fix: svm spoke client missing rpc (#1023)
549fee8 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@melisaguevara
feat(SvmSpokeUtils): implement findFillEvent (#998)
5ac115a
@melisaguevara
chore: reuse SVMProvider type (#1025)
ef8b147
@md0x
feat(svm): integration tests with test validator (#1015)
f7f5163 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@bmzig @pxrl
feat: Solana relayFeeCalculator and gasPriceOracle (#980)
0146d3c 
Signed-off-by: bennett <bennett@umaproject.org>
Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com>
@melisaguevara
improve: SVM getTimestampForSlot (#1026)
5bb6a2f
@bmzig @nicholaspai
@james-a-morris @pxrl @gsteenkamp89 @grasphoper @dohaki
chore: resync epic branch with master (#1029)
68280e9 
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: Bennett <bennett@umaproject.org>
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>
Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com>
Co-authored-by: Gerhard Steenkamp <51655063+gsteenkamp89@users.noreply.github.com>
Co-authored-by: Ihor Farion <65650773+grasphoper@users.noreply.github.com>
Co-authored-by: nicholaspai <npai.nyc@gmail.com>
Co-authored-by: Dong-Ha Kim <dongha.kim210@gmail.com>
@bmzig
Revert "chore: resync epic branch with master (#1029)"
bfd4550 
This reverts commit 68280e9.
@bmzig
Merge branch 'master' into epic/svm-client
4c1d608 
Signed-off-by: bennett <bennett@umaproject.org>
@md0x
feat: add request slow fill and fill functions and event tests (#1028)
9b3bb77 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@gsteenkamp89
feat(svm-eventsClient): add methods to find deposit and fills from si…
9d93433 
…gnature (#1033)

Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
@md0x
feat(svm): add svm test node hook at root level (#1037)
5582642 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x md0x requested a review from james-a-morris May 16, 2025 16:48
@md0x
fix: current time in tests
a9f7199 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
md0x
md0x commented May 16, 2025
View reviewed changes
@md0x
refactor: remove catch
15856e1 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x md0x requested review from Reinis-FRP and pxrl May 16, 2025 17:17
md0x added 3 commits May 16, 2025 19:31
@md0x
fix: test
c392dac 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x
refactor: simplify path
2fc707f 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x
Merge branch 'master' into pablo/svm-binaries
cfde0c7
@md0x md0x changed the base branch from epic/svm-client to master May 16, 2025 19:01
melisaguevara
melisaguevara approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@melisaguevara melisaguevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
Only one suggestion

Reinis-FRP
Reinis-FRP reviewed May 20, 2025
View reviewed changes
james-a-morris
james-a-morris reviewed May 20, 2025
View reviewed changes
Copy link
Member

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance we can rebase so that we don't have the tonne of commits

@md0x
Copy link
Contributor Author

md0x commented May 26, 2025

any chance we can rebase so that we don't have the tonne of commits

@james-a-morris There are a bunch of conflicts and file renames when rebasing, though. All the commits will get squashed into one when we merge anyway.

@md0x
fix: revert to 4.0.9 contracts to update in different pr
a4d2e6a 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x md0x force-pushed the pablo/svm-binaries branch 3 times, most recently from 3be254f to 0dae2a5 Compare May 26, 2025 15:24
@md0x md0x requested review from Reinis-FRP and melisaguevara May 26, 2025 15:26
@md0x
test: update testcase
51254f5 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x md0x force-pushed the pablo/svm-binaries branch 2 times, most recently from 2d6cd3f to 0da8f92 Compare May 27, 2025 14:27
@md0x
fix: test
0a3387b 
Signed-off-by: Pablo Maldonado <pablomaldonadoturci@gmail.com>
@md0x md0x force-pushed the pablo/svm-binaries branch from 0da8f92 to 0a3387b Compare May 27, 2025 14:31
@md0x md0x merged commit 3d8321c into master May 27, 2025
4 checks passed
@md0x md0x deleted the pablo/svm-binaries branch May 27, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-a-morris james-a-morris james-a-morris left review comments

@Reinis-FRP Reinis-FRP Reinis-FRP approved these changes

@pxrl pxrl Awaiting requested review from pxrl

@melisaguevara melisaguevara Awaiting requested review from melisaguevara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@md0x @melisaguevara @Reinis-FRP @james-a-morris @pxrl @bmzig @gsteenkamp89 @dohaki