Skip to content

feat(svm): Initial SpokeUtils skeleton #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 8, 2025

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Apr 2, 2025

No description provided.

@pxrl pxrl changed the base branch from master to pxrl/evmRelocate April 3, 2025 15:23
@pxrl pxrl force-pushed the pxrl/svmSpokeUtils branch 2 times, most recently from 6d31ae9 to b6b5e5d Compare April 3, 2025 15:27
Base automatically changed from pxrl/evmRelocate to master April 4, 2025 14:27
@pxrl pxrl requested a review from james-a-morris April 4, 2025 16:37
@pxrl pxrl force-pushed the pxrl/svmSpokeUtils branch from 89db313 to 0da1adf Compare April 4, 2025 16:42
pxrl added 5 commits April 4, 2025 19:07
…966)

The destinationChainId is implied by the SpokePool being queried, so
remove it as an argument.

While here, add fillStatusArray to the set of abstract methods
required by the SpokePoolClient. This is useful down in the relayer.
@pxrl pxrl changed the base branch from master to epic/svm-client April 8, 2025 16:33
Copy link
Member

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - as discussed we're not aiming for performance but availability of underlying code.

@melisaguevara melisaguevara marked this pull request as ready for review April 8, 2025 18:12
@melisaguevara melisaguevara merged commit 6b1b65a into epic/svm-client Apr 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants