improve(SpokePoolClient): Remove redundant relayFillStatus argument #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destinationChainId is implied by the SpokePool being queried, so remove it as an argument.
|
Corresponding relayer PR: across-protocol/relayer#2172 |
bmzig
approved these changes
Apr 4, 2025
md0x
pushed a commit
that referenced
this pull request
May 2, 2025
…966) The destinationChainId is implied by the SpokePool being queried, so remove it as an argument. While here, add fillStatusArray to the set of abstract methods required by the SpokePoolClient. This is useful down in the relayer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destinationChainId is implied by the SpokePool being queried, so
remove it as an argument.
While here, add
fillStatusArrayto the set of abstract methodsrequired by the SpokePoolClient. This is useful down in the relayer.