chore: resync epic branch with master #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at do not map to PoolRebalanceRoutes (#970)
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
Signed-off-by: james-a-morris <jaamorris@cs.stonybrook.edu>
This reverts commit 9bce8dd. This change unfortunately causes some widespread issues in the relayer repository. Back it out for now to permit other changes to proceed. This change can be re-proposed once the corresponding relayer updates are ready.
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org> Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>
Signed-off-by: bennett <bennett@umaproject.org> Signed-off-by: Bennett <bennett@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org> Co-authored-by: nicholaspai <npai.nyc@gmail.com>
Signed-off-by: bennett <bennett@umaproject.org>
#1021) Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
The Viem ABI encoder permits supplying the ABI as an object, which is faster than ethers, which apparently requires that the ABI be supplied to AbiCoder.encode() as a string. This implies re-parsing the same ABI on each call. Brief testing showed that the new implementation is 50% faster than the existing one. Producing 500 RelayData hashes locally with takes ~0.5 seconds with viem and ~1 second with ethers. This is relevant in the relayer because performs bulk fillStatus queries of up to 250 RelayData hashes per chain on update, and it has a loop time in the order of low-digit seconds.
Signed-off-by: bennett <bennett@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be overkill to open up a whole PR for this. This should give the epic branch all the general svm changes which were committed to master.