Skip to content

improve: refactor common interfaces #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

improve: refactor common interfaces #992

merged 3 commits into from
Apr 28, 2025

Conversation

james-a-morris
Copy link
Member

Reverts #986

pxrl
pxrl approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a merge conflict on EventUtils.ts - this PR previously modified the event sorting implementations, but that's no longer required after they were updated in another commit.

@pxrl
Copy link
Contributor

pxrl commented Apr 25, 2025

Also, the corresponding relayer PR for this is now passing tests: across-protocol/relayer#2191

@james-a-morris james-a-morris merged commit ae5519e into master Apr 28, 2025
4 checks passed
md0x pushed a commit that referenced this pull request May 2, 2025
@james-a-morris
improve: refactor common interfaces (#992)
d2e3112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxrl pxrl pxrl approved these changes

@nicholaspai nicholaspai Awaiting requested review from nicholaspai

@bmzig bmzig Awaiting requested review from bmzig

@amateima amateima Awaiting requested review from amateima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-a-morris @pxrl