feat(SvmSpokeUtils): implement findFillEvent #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisaguevara
requested review from
pxrl,
james-a-morris,
bmzig,
md0x and
Reinis-FRP
src/arch/svm/SpokeUtils.ts
Outdated
| destinationChainId: number, | ||
| svmEventsClient: SvmCpiEventsClient, | ||
| fromSlot: number, | ||
| toSlot?: number | bigint |
There was a problem hiding this comment.
Should we enforce one or the other?
There was a problem hiding this comment.
I think enforcing fromSlot is enough since the events client will always start fetching signatures from the current confirmed slot no matter if toSlot is defined or not. wdyt?
There was a problem hiding this comment.
Sorry - i meant should we enforce that the toSlot is a number or is a bigint? (it's okay if they're undefined).
There was a problem hiding this comment.
my bad! Done here 9e50877
md0x
approved these changes
May 2, 2025
There was a problem hiding this comment.
I agree with @james-a-morris’s comments, but otherwise this looks good to me!
|
Happy to sync on this - I will approve to not block #998 (comment) |
james-a-morris
approved these changes
May 6, 2025
melisaguevara
changed the base branch from
mguevara/acx-4029-relay-fill-status
to
epic/svm-client
james-a-morris
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
findFillEventimplementation for SVM chains. It looks for fill events in the PDA derived from the requested relayData.