Push 24.0 release into main again #8086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces#8048) The LorisFormDictionaryImpl trait for instruments was using the $this->lorisinstance variable which happens to be null in survey instruments, replaced with $this->loris instanciated in the constructor of NDB_Page and now it works Resolves aces#8021 Resolves aces#8020
Fixes a syntax error in the database query for add permission functionality for unversioned files. Resolves aces#8023
Update test plan for issue tracker
Fix permission name in DQT test plan.
Fix permission name in user accounts test plan.
Fix behavioural qc test plan.
math function in smarty seems to be broken (deprecated?). Replate it with direct math as supported in smarty 3.
Resolves aces#8027
Removed some unrealistic expectations and redundant instructions
Updates the email component to use the pattern property for the email input. Also using the type property for the message to displayed to the user when email isn't matching the pattern property. See here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/email edit: I added frontend logic for if by any chance the php validation finds an error not caught by the frontend and so the user will get a notification that email is invalid. Resolves aces#7897
Made the upload file process better.
Resolves aces#5055
It's not realistic to ask a tester to look at each configuration field to see if it can be changed successfully and it as all the "expected" effect on LORIS. This propose to look at one field of each type to see if the value can be changed and saved.
aces#7978) The Description field of the annotation.json sidecar is recommended but not required.
…es#7956) Add site and project filters to behavioural qc module.
Fix some function calls with incorrect arguments in: - data_integrity/fix_candidate_age.php - data_integrity/score_instrument.php - lorisform_parser.php
Fix the datapicker default values for the "Date of Birth" and "Date of Birth Confirm" fields. Updates the testPlan.
This updates delete_timepoint and delete_candidate scripts to run smoothly.
Resolves aces#8059
This changes the candidate_profile template that loads the widgets of the candidate_profile page so that it catches the errors when loading candidate visit information. Specifically, this handles the issue where a candidate is affiliated with multiple sites and the user only has access to one of those sites and the candidate_profile page does not load by filtering out inacccessible timepoints.
Resolves aces#8040
This adds a test name cache in the getInstance function of the media provisioner to load each instrument only once instead of for each row. Resolves aces#8033
…se_INTO_MAIN_AGAIN
ridz1208
added
the
State: Blocked
Collaborator
Author
|
Blocked until @CamilleBeau verifies the effect of the last commit |
Collaborator
|
@CamilleBeau Any update on this? |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH