Skip to content

Conversation

@AlexandraLivadas
Copy link
Contributor

@AlexandraLivadas AlexandraLivadas commented Mar 23, 2022

Brief summary of changes

This PR changes the candidate_profile template that loads the widgets of the candidate_profile page so that it catches the errors when loading candidate visit information. Specifically, this handles the issue where a candidate is affiliated with multiple sites and the user only has access to one of those sites and the candidate_profile page does not load.

  • Have you updated related documentation?

Testing instructions

  1. Create a user with access_all_profiles permission and only give them permission for one site
  2. Find a candidate that has some of its visits at the site your user is affiliated with and some of its visits at other sites your user should not have permission for
  3. Go to the candidate_profile page of this candidate
  4. See that the page loads correctly
  5. See that the list of visits does not include any of the visits that your user doesn't have permission to view.

Link(s) to related issue(s)

@AlexandraLivadas AlexandraLivadas marked this pull request as ready for review March 23, 2022 18:56
@AlexandraLivadas AlexandraLivadas requested review from CamilleBeau, cmadjar and driusan and removed request for cmadjar March 23, 2022 18:57
Copy link
Collaborator

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profile is now loading!

@driusan driusan merged commit 173e217 into aces:24.0-release Mar 24, 2022
@ridz1208 ridz1208 added this to the 24.0.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants