Skip to content

Conversation

@racostas
Copy link
Contributor

@racostas racostas commented Mar 16, 2022

Brief summary of changes

Fix the datapicker default values for the "Date of Birth" and "Date of Birth Confirm" fields. Updates the testPlan.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Go to the Configuration module and change the "Minimum candidate age" value.
  2. Now go to the new_profile module and make sure "Date of Birth" and "Date of Birth Confirm" fields
    properly reflects the changes.
  3. Go again to the Configuration and now delete the value in the "Minimum candidate age" field, and save.
  4. Now go to the new_profile module again make sure "Date of Birth" and "Date of Birth Confirm" fields have as the maximum possible value to choose the current day.

Link(s) to related issue(s)

@racostas racostas added 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Critical to release PR or issue is key for the release to which it has been assigned labels Mar 16, 2022
Copy link
Collaborator

@CamilleBeau CamilleBeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed in all DateElements, but only set as the MaxYear for the date of birth element specifically.

@racostas racostas marked this pull request as draft March 22, 2022 19:26
@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Mar 22, 2022
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@racostas racostas removed the State: Needs work PR awaiting additional work by the author to proceed label Mar 22, 2022
@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Mar 22, 2022
@driusan
Copy link
Collaborator

driusan commented Mar 23, 2022

This can't be merged because it's marked as a draft..

@racostas racostas marked this pull request as ready for review March 23, 2022 13:32
@racostas racostas requested a review from driusan March 23, 2022 13:33
@driusan driusan merged commit 5b0ccf5 into aces:24.0-release Mar 23, 2022
@ridz1208 ridz1208 added this to the 24.0.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Critical to release PR or issue is key for the release to which it has been assigned Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Create profile] - very limited # of years and month available when creating a new profile

5 participants