use github style uri when using git protocol.#616
Merged
evieluvsrainbows merged 1 commit intoVundleVim:masterfrom Jul 9, 2015
Merged
use github style uri when using git protocol.#616evieluvsrainbows merged 1 commit intoVundleVim:masterfrom
evieluvsrainbows merged 1 commit intoVundleVim:masterfrom
Conversation
Contributor
|
@luochen1990 People can easily create an SSH key & link it to their GitHub account easily by following GitHub's instructions here, so I don't see why people can't take 2 minutes out of their time to add an SSH key to their GitHub account, so I'm gonna merge this, then update the urls to the git@github.com one. |
evieluvsrainbows
pushed a commit
that referenced
this pull request
Jul 9, 2015
use github style uri when using git protocol.
Contributor
|
@KamranMackey this shouldn't have been merged as is at least because it lacks documentation. Please consult other team members before merging. Require at least 2 confirmations. |
evieluvsrainbows
referenced
this pull request
Jul 9, 2015
Signed-off-by: Kamran Mackey <kamranm1200@gmail.com>
This was referenced Jul 9, 2015
Contributor
|
@luochen1990 @KamranMackey this is not an issue. See #615 (comment) for more details and workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #615. And I found that there is a similar pull request #232, but this one is better.
there is still some problem leaving:
git@github.com:style uri, user need to provide public key to clone/fetch, which is not necessary indeed. This can be solved this way:git remote set-url --push ..., but I'm not sure if we really need to do it like this.autoload/vundle/scripts.vimat line 93, the pattern"https://github.com"is used, and I'm not sure if we should consider different protocols here.