Skip to content

use github style uri when using git protocol. #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evieluvsrainbows merged 1 commit into from
Jul 9, 2015
Merged

use github style uri when using git protocol. #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions autoload/vundle/config.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,11 @@ endf
func! s:parse_name(arg)
let arg = a:arg
let git_proto = exists('g:vundle_default_git_proto') ? g:vundle_default_git_proto : 'https'
let github_uri_prefix = (git_proto == 'git' ? 'git@github.com:' : git_proto.'://github.com/')

if arg =~? '^\s*\(gh\|github\):\S\+'
\ || arg =~? '^[a-z0-9][a-z0-9-]*/[^/]\+$'
let uri = git_proto.'://github.com/'.split(arg, ':')[-1]
let uri = github_uri_prefix . split(arg, ':')[-1]
if uri !~? '\.git$'
let uri .= '.git'
endif
Expand All @@ -153,7 +154,7 @@ func! s:parse_name(arg)
let name = split( substitute(uri,'/\?\.git\s*$','','i') ,'\/')[-1]
else
let name = arg
let uri = git_proto.'://github.com/vim-scripts/'.name.'.git'
let uri = github_uri_prefix . '/vim-scripts/'.name.'.git'
endif
return {'name': name, 'uri': uri, 'name_spec': arg }
endf
Expand Down
2 changes: 1 addition & 1 deletion autoload/vundle/scripts.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func! s:create_changelog() abort
call add(changelog, '')
call add(changelog, 'Updated Plugin: '.bundle.name)

if bundle.uri =~ "https://github.com"
if bundle.uri =~ "https://github.com" "TODO: what for git protocol?
call add(changelog, 'Compare at: '.bundle.uri[0:-5].'/compare/'.initial_sha.'...'.updated_sha)
endif

Expand Down