Skip to content

Revert "use github style uri when using git protocol."#617

Closed
evieluvsrainbows wants to merge 8 commits intomasterfrom
revert-616-fix-github-url
Closed

Revert "use github style uri when using git protocol."#617
evieluvsrainbows wants to merge 8 commits intomasterfrom
revert-616-fix-github-url

Conversation

@evieluvsrainbows
Copy link
Contributor

Reverts #616

wolph and others added 8 commits May 28, 2015 23:08
use github style uri when using git protocol.
added support for specifying specific branch/tag/revision while installing
Signed-off-by: Kamran Mackey <kamranm1200@gmail.com>
Signed-off-by: Kamran Mackey <kamranm1200@gmail.com>
Signed-off-by: Kamran Mackey <kamranm1200@gmail.com>
@evieluvsrainbows
Copy link
Contributor Author

@gmarik reverted #616, can this be merged?

@gmarik
Copy link
Contributor

gmarik commented Jul 9, 2015

@KamranMackey let's do hard reset instead. to cfd3b2d

@evieluvsrainbows
Copy link
Contributor Author

@gmarik you just removed all of the permissions from everyone when doing that hard reset. It no longer says that I'm a collaborator.

@gmarik
Copy link
Contributor

gmarik commented Jul 9, 2015

@KamranMackey not everyone. Mindless PR merging doesn't help anyone especially if someone else has to fix it later. But thanks for trying!

@evieluvsrainbows
Copy link
Contributor Author

@gmarik please give me back my permissions. I'm sorry for the mindless PR merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants