added support for specifying specific branch/tag/revision while installing

[wolph]

This fixes #35

Now it's possible to specify a tag, branch or revision using @...:

Example: Plugin 'WoLpH/nerdtree@patch-1'

[luochen1990]

'git reset --hard origin/'.a:bundle.revision,
I think this is what you want (which was done in line 396 in a wrong way) ?

[wolph]

That would probably work too. In what way is line 396 wrong? I've been using this fork for a while without any issues

[luochen1990]

It's usual that the wrong codes "works", but this doesn't means it's right.

What if the a:bundle.revision branch uses a new submodule ?

[evieluvsrainbows]

Merging, since this seems like a pretty cool feature.

[evieluvsrainbows]

I'll fix it afterwards.

[gmarik]

Merging, since this seems like a pretty cool feature.

@KamranMackey

1. have anyone other than author tested it?
2. is it backward compatible?

Before merging require atleast 2 confirmation from other team members

/cc @VundleVim/team

[evieluvsrainbows]

@gmarik Oh yeah, crap. Forgot about that. Sorry.

[gmarik]

@KamranMackey while it's not too late i'd suggest hard resetting it back to where it was before. Otherwise you'll get flooded with support issues very soon…

[gmarik]

@KamranMackey let's figured out process first before getting to merging code. Ok?

[evieluvsrainbows]

@gmarik created a PR that reverts #616, since that's the one that might've broken Vundle. I doubt this one did.

[luochen1990]

@KamranMackey intersting...

[wolph]

@gmarik @KamranMackey Perhaps it's time to look at Travis tests? Doesn't have to be fully covering initially but some automated tests might help with accepting pull requests.

[silfverstrom]

@wolph +1 on adding some automated test-coverage.

[gmarik]

👍 if anyone want's to figure out testing process…

[gmarik]

@silfverstrom create separate issues for testing?

[silfverstrom]

@gmarik yeah I'll add a new issue.

[fearphage]

Is any of this ever coming to master?

[ryanoasis]

@fearphage Good question. I tried getting a next release branch up but we had some issues. I still want to help release the next version but really paranoid about breaking vundle (considering how many vim users use it still).

I have been too busy but hopefully in a few weeks I can contribute more. I have only been merging the most trivial of PRs.