Repository navigation
fix(interop): initialise the x265 CSV column indices so gcc -O2 sees no maybe-uninitialized - #79
Merged
Merged
Conversation
…no maybe-uninitialized gcc 16 at -O2 -Wall -Wextra raised seven -Wmaybe-uninitialized warnings on the column struct of x265_csv_read_rows(). Start every index at -1 (absent). CI gains an optimised gcc build with werror.
4 of 9 tasks
lusoris
added a commit
that referenced
this pull request
Oct 8, 2026
…onto master The rebase onto 11e183e kept master's side of the two generated files at each conflicting stop, so this commit renders them once at the tip. CHANGELOG.md is rendered from changelog.d/ with `scripts/release/concat-changelog-fragments.sh --write`; it now carries the fragments from both this branch and master (#77, #78, #79, #89, #91). .standards-baseline.json is re-recorded with the pinned engine (0af07a73, `standardsctl baseline --record`) at 51 infractions: 28 HISS-01, 21 HISS-04, two HISS-07. That is the branch's 56 minus the five interop and x265 CSV entries that #77 cleared. Every recorded fingerprint is also present in master's baseline (93) and in the branch's previous one (56), so no finding is added. README and docs/development/build.md state the new count. The FFmpeg patch stack regenerates byte for byte against n9.0.2, so it is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lusoris
added a commit
that referenced
this pull request
Oct 8, 2026
…onto master The rebase onto 11e183e kept master's side of the two generated files at each conflicting stop, so this commit renders them once at the tip. CHANGELOG.md is rendered from changelog.d/ with `scripts/release/concat-changelog-fragments.sh --write`; it now carries the fragments from both this branch and master (#77, #78, #79, #89, #91). .standards-baseline.json is re-recorded with the pinned engine (0af07a73, `standardsctl baseline --record`) at 51 infractions: 28 HISS-01, 21 HISS-04, two HISS-07. That is the branch's 56 minus the five interop and x265 CSV entries that #77 cleared. Every recorded fingerprint is also present in master's baseline (93) and in the branch's previous one (56), so no finding is added. README and docs/development/build.md state the new count. The FFmpeg patch stack regenerates byte for byte against n9.0.2, so it is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLUF: gcc 16 at -O2 -Wall -Wextra reports 7 -Wmaybe-uninitialized warnings in qp_report_csv.c; this initialises the column struct and adds a CI build that would have caught it.
csv_cols colsinx265_csv_read_rows()is uninitialised until the header row is seen; the optimiser cannot prove the header path always runs first. Every index now starts at -1 (absent), which every reader already treats as a missing column. No behaviour change.