Repository navigation
refactor(interop): split the side-data packer, the section finder and the x265 CSV reader (HISS-04, HISS-02) - #77
Merged
Conversation
… the x265 CSV reader (HISS-04, HISS-02) Five baselined HISS infractions in libpelorus/src/interop.c and qp_report_csv.c: pel_blob_pack, pel_blob_find_section and pel_qp_report_from_blocks are split into helpers, pel_x265_csv_parse reads its rows in a helper, and split_fields() counts its steps against PEL_CSV_LINE_MAX. Behaviour is unchanged; the conformance fixture and the fast suite pass.
…ository a hook runs in Git exports GIT_DIR and GIT_WORK_TREE to hooks, and the fixtures of scripts/check-build-config.py --self-test inherited them. Run from the pre-push hook they committed fixture commits onto the pushed branch, created the branches base and n1.2.3 and wrote core.hooksPath, commit.gpgsign, gpg.program, diff.orderFile, filter.pelorus-fail and user.name into the real repository config. main() now drops the repository-selecting variables, and a self-test regression proves it; without the scrub the fixtures fail with "pathspec 'sample.txt' did not match any files". The file carried a baselined HISS-04 row, so renovate_validator_regressions() is split into a case table and two helpers (93 baselined, from 94).
11 of 17 tasks
Tualua
pushed a commit
to Tualua/vmafx
that referenced
this pull request
Oct 5, 2026
…hat carries the HISS splits (HISS-04, HISS-02) (VMAFx#2117) * refactor(interop): re-vendor the Pelorus interop sources at the pin that carries the HISS splits (HISS-04, HISS-02) PELORUS_VENDOR_SHA moves to 013bc59f04f1 (VMAFx/pelorus#77), which splits pel_blob_pack, pel_blob_find_section, pel_qp_report_from_blocks and pel_x265_csv_parse and bounds split_fields(). The vendored files are rendered by scripts/sync-pelorus-interop.sh --update (ABI 1.3 unchanged; --check reports OK) and the nine baselined rows they carried are gone (baseline 173 to 164). The pin also brings Pelorus's UTF-8 path opening for the qp-report CSV reader. * docs: regenerate the indexes and the citation map after rebasing
lusoris
added a commit
that referenced
this pull request
Oct 8, 2026
…onto master The rebase onto 11e183e kept master's side of the two generated files at each conflicting stop, so this commit renders them once at the tip. CHANGELOG.md is rendered from changelog.d/ with `scripts/release/concat-changelog-fragments.sh --write`; it now carries the fragments from both this branch and master (#77, #78, #79, #89, #91). .standards-baseline.json is re-recorded with the pinned engine (0af07a73, `standardsctl baseline --record`) at 51 infractions: 28 HISS-01, 21 HISS-04, two HISS-07. That is the branch's 56 minus the five interop and x265 CSV entries that #77 cleared. Every recorded fingerprint is also present in master's baseline (93) and in the branch's previous one (56), so no finding is added. README and docs/development/build.md state the new count. The FFmpeg patch stack regenerates byte for byte against n9.0.2, so it is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lusoris
added a commit
that referenced
this pull request
Oct 8, 2026
…onto master The rebase onto 11e183e kept master's side of the two generated files at each conflicting stop, so this commit renders them once at the tip. CHANGELOG.md is rendered from changelog.d/ with `scripts/release/concat-changelog-fragments.sh --write`; it now carries the fragments from both this branch and master (#77, #78, #79, #89, #91). .standards-baseline.json is re-recorded with the pinned engine (0af07a73, `standardsctl baseline --record`) at 51 infractions: 28 HISS-01, 21 HISS-04, two HISS-07. That is the branch's 56 minus the five interop and x265 CSV entries that #77 cleared. Every recorded fingerprint is also present in master's baseline (93) and in the branch's previous one (56), so no finding is added. README and docs/development/build.md state the new count. The FFmpeg patch stack regenerates byte for byte against n9.0.2, so it is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Five baselined HISS infractions in
libpelorus/src/interop.candqp_report_csv.care removed:pel_blob_pack,pel_blob_find_sectionandpel_qp_report_from_blocksare split into helpers,pel_x265_csv_parsereads its rows in a helper, andsplit_fields()counts its steps againstPEL_CSV_LINE_MAXinstead of looping withfor (;;). Behaviour is unchanged. This is the Pelorus half of VMAFx's "HISS baseline to zero": VMAFx vendors these files byte for byte (ADR-1113) and re-vendors them after this merges. The baseline goes 99 to 93 (the sixth row isscripts/check-build-config.py, see below).A second commit fixes a defect found on the way:
scripts/check-build-config.py --self-testran its Git fixtures against the repository being pushed when started from the pre-push hook (Git exportsGIT_DIR/GIT_WORK_TREEto hooks). The first push attempt committedfixturecommits onto this very branch, created the branchesbaseandn1.2.3and wrotecore.hooksPath,commit.gpgsign,gpg.program,diff.orderFile,filter.pelorus-failanduser.nameinto the repository config.main()now drops the repository-selecting variables and a self-test regression proves it; without the scrub the fixtures fail withpathspec 'sample.txt' did not match any files.Reproducer / smoke-test
Per-PR checklist (ADR-0100 / ADR-0108 — see CONTRIBUTING.md)
changelog.d/changed/0153-hiss-interop-split.md,changelog.d/fixed/0155-build-config-fixture-git-env.mdpraetorctl audit93 within 93)masterdirectly