Repository navigation
style(interop): clear the clang-tidy findings the VMAFx profile reports on the vendored sources - #78
Merged
Merged
Conversation
…ts on the vendored sources VMAFx lints the vendored copies of these files at its own clang-tidy profile (modernize-*, C23). Clear what it reports: split the conformance test's long checks into helpers, patch blob headers through memcpy instead of casting the byte buffer through void *, and keep the NULL macro in one NOLINT(modernize-use-nullptr) block per translation unit because MSVC's C mode has no nullptr. No behaviour or ABI change.
lusoris
added a commit
that referenced
this pull request
Oct 8, 2026
…onto master The rebase onto 11e183e kept master's side of the two generated files at each conflicting stop, so this commit renders them once at the tip. CHANGELOG.md is rendered from changelog.d/ with `scripts/release/concat-changelog-fragments.sh --write`; it now carries the fragments from both this branch and master (#77, #78, #79, #89, #91). .standards-baseline.json is re-recorded with the pinned engine (0af07a73, `standardsctl baseline --record`) at 51 infractions: 28 HISS-01, 21 HISS-04, two HISS-07. That is the branch's 56 minus the five interop and x265 CSV entries that #77 cleared. Every recorded fingerprint is also present in master's baseline (93) and in the branch's previous one (56), so no finding is added. README and docs/development/build.md state the new count. The FFmpeg patch stack regenerates byte for byte against n9.0.2, so it is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lusoris
added a commit
that referenced
this pull request
Oct 8, 2026
…onto master The rebase onto 11e183e kept master's side of the two generated files at each conflicting stop, so this commit renders them once at the tip. CHANGELOG.md is rendered from changelog.d/ with `scripts/release/concat-changelog-fragments.sh --write`; it now carries the fragments from both this branch and master (#77, #78, #79, #89, #91). .standards-baseline.json is re-recorded with the pinned engine (0af07a73, `standardsctl baseline --record`) at 51 infractions: 28 HISS-01, 21 HISS-04, two HISS-07. That is the branch's 56 minus the five interop and x265 CSV entries that #77 cleared. Every recorded fingerprint is also present in master's baseline (93) and in the branch's previous one (56), so no finding is added. README and docs/development/build.md state the new count. The FFmpeg patch stack regenerates byte for byte against n9.0.2, so it is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
VMAFx vendors
libpelorus/src/{interop,deband_params,denoise_params,qp_report_csv}.candlibpelorus/test/interop_test.cbyte for byte and lints the copies at its own clang-tidy profile (modernize-*, C23). Measured there (clang-tidy 22.1.8, cpu lane): 59 findings across these files. This PR clears them at the source so the mirror stays byte-identical:readability-function-size(8): the conformance test's long checks split into helpers; every assertion is kept.bugprone-casting-through-void(4): blob headers and the directory entry are patched throughmemcpyon the byte buffer instead of a cast throughvoid *.modernize-use-nullptr(47): oneNOLINTBEGIN/END(modernize-use-nullptr)block per translation unit, citing that MSVC's C mode has nonullptrand VMAFx ADR-1138.No behaviour or ABI change. No ADR: implementation detail, and the NOLINT follows VMAFx ADR-1138.
Reproducer / smoke-test
Per-PR checklist (ADR-0100 / ADR-0108 — see CONTRIBUTING.md)
docs/adr/README.md(n/a: implementation detail; NOLINT follows VMAFx ADR-1138)docs/for every user-discoverable surface (n/a: test and lint cleanup, no user-visible surface)docs/research/NNNN-*.md(no digest needed: trivial)changelog.d/<section>/*.md;concat-changelog-fragments.sh --checkpassesdocs/rebase-notes.mdif the FFmpeg patch stack is affected (no rebase impact: libpelorus sources only, no patch input changed)// NOLINTcitedmasterdirectly