Repository navigation
fix(interop): re-vendor Pelorus with the x265 CSV column indices initialised (HISS-10) - #2154
Merged
Merged
Conversation
…ialised (HISS-10) (#2154) * fix(interop): re-vendor Pelorus with the x265 CSV column indices initialised (HISS-10) The vendored pelorus_qp_report_csv.c raised seven -Wmaybe-uninitialized warnings at gcc 16 -O2 -Wall -Wextra. The cause is fixed in VMAFx/pelorus (#79, merge 42cb17106a2d: every csv_cols index starts at -1); the pin moves and the mirror is re-rendered with scripts/sync-pelorus-interop.sh --update.
lusoris
force-pushed
the
fix/pelorus-qp-csv-maybe-uninit
branch
from
October 5, 2026 17:16
5db103f to
4e62e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLUF: the vendored
pelorus_qp_report_csv.cgave seven-Wmaybe-uninitializedwarnings at gcc 16-O2 -Wall -Wextra; the cause is fixed in VMAFx/pelorus and re-vendored here. HISS-10 (zero warnings) binds vendored code.csv_cols colsinx265_csv_read_rows()was uninitialised until the header row. Fixed upstream in VMAFx/pelorus#79 (merge42cb17106a2d): every index starts at -1 (absent), no pragma.PELORUS_VENDOR_SHAmoved, mirror re-rendered byscripts/sync-pelorus-interop.sh --update;--checkreports no drift.type,poc,qp,bits,psnr_y/u/v), 0 after, gcc 16.2.1-std=c11 -O2 -Wall -Wextra.test_pelorus_interoppasses.-Werror(core/meson.buildsetswarning_level=2only). Recorded in the state row; not changed here.scripts/ci/pelorus-mirror-paths.txt; the lane refuses them as TUs.Reproducer:
scripts/sync-pelorus-interop.sh <pelorus checkout>; gcc -std=c11 -O2 -Wall -Wextra -Icore/include -Icore/src -c core/src/interop/pelorus_qp_report_csv.c -o /dev/nullchangelog.d/fixed/pelorus-qp-csv-cols-initialised.mddocs/rebase-notes.mdentrydocs/api/pelorus-interop.mdupdated)