-
Notifications
You must be signed in to change notification settings - Fork 450
test: multiprocess tests part 6: fixing issues runnings all tests together #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0xFA11
merged 111 commits into
develop
from
test/multiprocess-tests/fixing-issues-runnings-all-tests-together
Jul 13, 2021
Merged
test: multiprocess tests part 6: fixing issues runnings all tests together #957
0xFA11
merged 111 commits into
develop
from
test/multiprocess-tests/fixing-issues-runnings-all-tests-together
Jul 13, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: moving orchestration to this branch from test/multiprocess-testing/wip
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: taking changes from wip branch
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: taking changes from wip branch
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: commenting out ExecuteStepInContext for better PR clarity
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: uncommenting here, this is where they should really be commenting out ExecuteStepInContext for better PR clarity
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: cleanup
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: cleanup
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: cleanup
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: better name
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: better name
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: better name
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: removing comment and putting better name
Fixed some typos Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration * 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: Apply suggestions from code review
…rocess-tests/base-multiprocess-tests * test/multiprocess-tests/orchestration: Applying suggestions Apply suggestions from code review consistent naming
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: format update
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: name fix # Conflicts: # testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: # name fix
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/base-multiprocess-tests * 'test/multiprocess-tests/base-multiprocess-tests' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi: fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
…est/multiprocess-tests/execute-step-in-context * test/multiprocess-tests/base-multiprocess-tests: fix for automation fail right now fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: fix for automation fail right now fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951) # Conflicts: # testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs
…ontext * develop: test: Perf tests part 2. Adding Test Coordinator and base test class (#923) # Conflicts: # testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
…est/multiprocess-tests/adding-perf-tests-for-spawn * test/multiprocess-tests/execute-step-in-context: test: Perf tests part 2. Adding Test Coordinator and base test class (#923)
Base automatically changed from
test/multiprocess-tests/adding-perf-tests-for-spawn
to
develop
July 12, 2021 23:57
…nings-all-tests-together * develop: test: Perf tests part 4. Adding example of performance test with spawning x network objects at once (#925) # Conflicts: # testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs # testproject/Assets/Tests/Runtime/MultiprocessRuntime/NetworkVariablePerformanceTests.cs
…nings-all-tests-together
0xFA11
approved these changes
Jul 13, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Jul 23, 2021
…nsform * develop: feat: snapshot. Adding RTT computation API. (#963) feat: snapshot. Milestone 1b. Testproject "manual test" "scene transitioning" working with snapshot. Disabled by default. (#862) test: multiprocess tests part 6: fixing issues runnings all tests together (#957) docs: Perf tests part 5. Adding documentation and instructions (#952) test: Perf tests part 4. Adding example of performance test with spawning x network objects at once (#925) test: Correctly teardown OnNetworkSpawn/Despawn tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some issues with latest playmode tests running all in the same batch.
Some tests weren't cleaning up properly.