Skip to content

test: multiprocess tests part 6: fixing issues runnings all tests together #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SamuelBellomo
Copy link
Contributor

There was some issues with latest playmode tests running all in the same batch.
Some tests weren't cleaning up properly.

SamuelBellomo and others added 30 commits June 27, 2021 15:58
…rocess-tests/base-multiprocess-tests

* test/multiprocess-tests/orchestration:
  moving orchestration to this branch from test/multiprocess-testing/wip
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  taking changes from wip branch
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  taking changes from wip branch
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  commenting out ExecuteStepInContext for better PR clarity
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  uncommenting here, this is where they should really be
  commenting out ExecuteStepInContext for better PR clarity
…rocess-tests/base-multiprocess-tests

* test/multiprocess-tests/orchestration:
  cleanup
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  cleanup
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  cleanup
…rocess-tests/base-multiprocess-tests

* test/multiprocess-tests/orchestration:
  better name
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  better name
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  better name
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  removing comment and putting better name
Fixed some typos

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>
…ity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/orchestration

* 'test/multiprocess-tests/orchestration' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi:
  Apply suggestions from code review
…rocess-tests/base-multiprocess-tests

* test/multiprocess-tests/orchestration:
  Applying suggestions
  Apply suggestions from code review
  consistent naming
SamuelBellomo and others added 20 commits July 8, 2021 23:00
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  format update
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  name fix

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  #
  name fix
…hub.com:Unity-Technologies/com.unity.multiplayer.mlapi into test/multiprocess-tests/base-multiprocess-tests

* 'test/multiprocess-tests/base-multiprocess-tests' of github.com:Unity-Technologies/com.unity.multiplayer.mlapi:
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
…est/multiprocess-tests/execute-step-in-context

* test/multiprocess-tests/base-multiprocess-tests:
  fix for automation fail right now
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  fix for automation fail right now
  fix: (MLAPI.Serialization) 'specified cast is not valid.' on NetworkW… (#951)

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/MultiprocessOrchestration.cs
…ontext

* develop:
  test: Perf tests part 2. Adding Test Coordinator and base test class (#923)

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
…est/multiprocess-tests/adding-perf-tests-for-spawn

* test/multiprocess-tests/execute-step-in-context:
  test: Perf tests part 2. Adding Test Coordinator and base test class (#923)
Base automatically changed from test/multiprocess-tests/adding-perf-tests-for-spawn to develop July 12, 2021 23:57
SamuelBellomo and others added 2 commits July 13, 2021 10:08
…nings-all-tests-together

* develop:
  test: Perf tests part 4. Adding example of performance test with spawning x network objects at once (#925)

# Conflicts:
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/Helpers/BuildMultiprocessTestPlayer.cs
#	testproject/Assets/Tests/Runtime/MultiprocessRuntime/NetworkVariablePerformanceTests.cs
@0xFA11 0xFA11 enabled auto-merge (squash) July 13, 2021 19:53
@0xFA11 0xFA11 merged commit 13e2b7f into develop Jul 13, 2021
@0xFA11 0xFA11 deleted the test/multiprocess-tests/fixing-issues-runnings-all-tests-together branch July 13, 2021 20:02
SamuelBellomo added a commit that referenced this pull request Jul 23, 2021
…nsform

* develop:
  feat: snapshot. Adding RTT computation API. (#963)
  feat: snapshot. Milestone 1b. Testproject "manual test" "scene transitioning" working with snapshot. Disabled by default. (#862)
  test: multiprocess tests part 6: fixing issues runnings all tests together (#957)
  docs: Perf tests part 5. Adding documentation and instructions (#952)
  test: Perf tests part 4. Adding example of performance test with spawning x network objects at once (#925)
  test: Correctly teardown OnNetworkSpawn/Despawn tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants