fix: Adding exception for silent failure for clients getting other player's object #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… silent failures calling this client side expecting to see other player objects. This solves issue #581
SamuelBellomo
changed the title
SamuelBellomo
changed the title
com.unity.multiplayer.mlapi/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
May 19, 2021
| /// </summary> | ||
| /// <returns>The player object with a given clientId or null if one does not exist</returns> | ||
| public NetworkObject GetPlayerNetworkObject(ulong clientId) | ||
| { | ||
| if (!NetworkManager.Singleton.IsServer && NetworkManager.Singleton.LocalClientId != clientId) | ||
| { | ||
| throw new NotServerException("Only the server can find player objects from other clients."); |
Adding the possibility to have multiple clients in MultiInstanceHelpers Updating exception check to make sure to use local networkmanager (so it works with tests)
…player-object-get * develop: test: manual connection approval to fully automated connection approval testing (#839) test: manual rpc tests to automated fixed revision (#841) fix: CleanDiffedSceneObjects was not clearing PendingSoftSyncObjects (#834) feat: NetworkTransform now uses NetworkVariables instead of RPCs (#826) fix: gracefully handle exceptions in an RPC invoke (#846) fix: Fixing utp license file for legal (#843) ci: enable standards check on UTP too (#837) refactor: NetworkBehaviour.NetworkObject no longer throws an exception (#838) fix: revert #830 (#840) test: converting the manual rpc tests over to an automated unit test (#830) # Conflicts: # com.unity.multiplayer.mlapi/Tests/Runtime/MultiInstance/MultiInstanceHelpers.cs
Adding separate tests in SpawnManagerTests. Added Teardown
|
Added tests and necessary improvement to multi instance helper. |
0xFA11
approved these changes
May 21, 2021
…player-object-get
SamuelBellomo
deleted the
feature/adding-exception-for-client-side-player-object-get
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this issue myself in our test project and I'm seeing there's already an issue opened for this here
#581
This fixes a silent fail where a client would expect to see other player's objects in that list, but would only get its own player object.
Only the server will see other player objects.
This doesn't solve the issue with actually adding other clients to a client's list. Some games might want to hide other players from each other or AoI could hide some players. This shouldn't be handled here.
Users can still tracking players spawning themselves (it's a one liner to statically track player spawns in a Dictionary)