Skip to content

fix: snapshot system. Properly gating the SnapshotSystem from being u… #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

fix: snapshot system. Properly gating the SnapshotSystem from being u… #852

merged 1 commit into from
May 21, 2021

Conversation

jeffreyrainy
Copy link
Contributor

…sed until is is ready and specifically enabled

@jeffreyrainy
fix: snapshot system. Properly gating the SnapshotSystem from being u…
9ab43b8 
…sed until is is ready and specifically enabled
pdeschain
pdeschain approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@pdeschain pdeschain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

NoelStephensUnity
NoelStephensUnity approved these changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

TwoTenPvP
TwoTenPvP approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@TwoTenPvP TwoTenPvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. IsConnectedClient is going to solve all my world problems haha

@jeffreyrainy jeffreyrainy merged commit d796d78 into develop May 21, 2021
@jeffreyrainy jeffreyrainy deleted the fix/snapshot-system-disable branch May 21, 2021 18:00
SamuelBellomo added a commit that referenced this pull request May 21, 2021
@SamuelBellomo
Merge branch 'develop' into feature/adding-exception-for-client-side-…
6343644 
…player-object-get

* develop:
  fix: snapshot system. Properly gating the SnapshotSystem from being used until is is ready and specifically enabled (#852)
  test:  verifies that a user can use INetworkSerializable with RPCs (#850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeschain pdeschain pdeschain approved these changes

@TwoTenPvP TwoTenPvP TwoTenPvP approved these changes

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffreyrainy @pdeschain @TwoTenPvP @NoelStephensUnity