Skip to content

test: verifies that a user can use INetworkSerializable with RPCs #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 21, 2021
Merged

test: verifies that a user can use INetworkSerializable with RPCs #850

merged 8 commits into from
May 21, 2021

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 20, 2021 •
edited
Loading

Summary
This task is to verify the user can define their own custom network serialized type.
This task is based on the following user stories:
MTT-787
MTT-788

Acceptance Criteria
A user should be able to implement the INetworkSerializable interface within a class and use that class as an RPC Parameter to pass between both client and server RPCs. The test should include the reading and writing of custom values within the custom INetworkSerializable based class.

A user should be able to send arrays of the same class type that implements the INetworkSerializable interface and expect the array to maintain the exact same order from when it was sent to when it is received.

Acceptance Tests
From TestRunner:
TestProject->RuntimeTests->RpcINetworkSerializable->NetworkSerializableTest
TestProject->RuntimeTests->RpcINetworkSerializable->NetworkSerializableArrayTest

@NoelStephensUnity
test
74e52f6 
This test verifies that a user can use INetworkSerializable with an RPC.
@NoelStephensUnity
style
3268b67 
Some style clean up along with additional comments.
@NoelStephensUnity
refactor
e7670ed 
Extending this test to include T2910450 manual test:
	Verify arrays of custom types are being serialized in the exact same order in both ends.
@NoelStephensUnity
refactor
cfccf2d 
Actually had to refactor the previous commit as I misunderstood the test rail manual test's description.  This implements a new test, NetworkSerializableArrayTest, that covers T2910450.
@NoelStephensUnity
refactor and style
bd5a549 
Removing duplicate code and one additional check that was no longer needed.
Updated comments to better reflect the newly added test.
@NoelStephensUnity
style
706e3f0 
Cleaned up some comments and minor things like spaces etc.
@NoelStephensUnity
style
29e952c 
Minor comment adjustment.
@NoelStephensUnity
style
857fe43 
very minor carriage return didn't seem to make it after a comment.
TwoTenPvP
TwoTenPvP approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@TwoTenPvP TwoTenPvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👌🏻

@NoelStephensUnity NoelStephensUnity merged commit 086a55a into develop May 21, 2021
@NoelStephensUnity NoelStephensUnity deleted the test/INetworkSerializable branch May 21, 2021 13:46
SamuelBellomo added a commit that referenced this pull request May 21, 2021
@SamuelBellomo
Merge branch 'develop' into feature/adding-exception-for-client-side-…
6343644 
…player-object-get

* develop:
  fix: snapshot system. Properly gating the SnapshotSystem from being used until is is ready and specifically enabled (#852)
  test:  verifies that a user can use INetworkSerializable with RPCs (#850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoTenPvP TwoTenPvP TwoTenPvP approved these changes

@mattwalsh-unity mattwalsh-unity Awaiting requested review from mattwalsh-unity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @TwoTenPvP