refactor: Refactor spawncall and improve error handling for spawning #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwalsh-unity
approved these changes
Mar 5, 2021
mattwalsh-unity
added a commit
that referenced
this pull request
Mar 9, 2021
* revert: Add NetworkAddress and NetworkPort properties to Transport. (#512) (#529) This reverts commit feea3c1. * test: expose runtime internals to runtime tests asmdef (#534) * ci: enable yamato on PRs targeting master, develop and release/* branches (#535) * ci: enable yamato on PRs targeting the release/0.1.0 branch * update branch targets: master, develop, release/* * replace 'release/*' regex match with 'release/*' pattern match * ci: enable conventional PR checks on PRs targeting release branches (#536) * ci: enable conventional PR checks on release branches * remove release/* wildcard since release/** covers all * fix: Correctly collecting and drawing counters on dynamic modules (#539) * refactor: Improve error messages for NetworkPrefab list. (#538) * refactor: Refactor spawncall and improve error handling for client side spawning (#537) * fix: re-fix yamato release branch wildcard regex (#542) * fix: NetworkWriter.WriteObjectPacked to call WriteBool instead of WriteBit when serializing bool object (#541) * fix: revert Application.isPlaying check in NetworkScenePostProcess (#550) * test: implement test for NetworkUpdateLoop injecting NetworkUpdateStages into the PlayerLoop (#554) * initial wip * implement networkupdatestage injection test * refactor: rename spawn/destroy register/unregister methods (#551) * test: implement extra features on top of existing NetworkUpdateLoopTests to cover other test cases (#559) * implement extra features on top of existing tests to cover other test cases too * minor update Co-authored-by: M. Fatih MAR <mfatihmar@gmail.com> Co-authored-by: Jean-Sébastien Fauteux <js.fauteux@unity3d.com> Co-authored-by: Luke Stampfli <43687322+LukeStampfli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Before this fix you get an unclear KeyNotFound exception when trying to spawn an object on a client)