[GEN][ZH] Fix broken replay list when it contains a replay with an unknown map #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
force-pushed
the
xezon/fix-broken-replaylist
branch
from
ae0cfd3 to
281d77a
Compare
xezon
force-pushed
the
xezon/fix-broken-replaylist
branch
from
281d77a to
c249f62
Compare
xezon
changed the title
Author
|
In reality, this change did not really fix the List Box bug. It just reduced its likelyhood by reducing the height of rows, which is fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change fixes the broken replay list when it contains a replay with an unknown map.This change decreases the amount of text for missing map row entries in the Replay Menu List Box. It reduces the likelyhood of a broken map list without fix #1023.