Skip to content

[GEN][ZH] Fix broken replay list when it contains a replay with an unknown map #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

[GEN][ZH] Fix broken replay list when it contains a replay with an unknown map #732

merged 1 commit into from
Apr 21, 2025

Conversation

xezon
Copy link

@xezon xezon commented Apr 20, 2025 •
edited
Loading

Merge with Rebase

This change fixes the broken replay list when it contains a replay with an unknown map.

@xezon xezon added Bug Something is not working right Critical Severity: Minor < Major < Critical < Blocker GUI For graphical user interface Gen Relates to Generals ZH Relates to Zero Hour labels Apr 20, 2025
@xezon xezon force-pushed the xezon/fix-broken-replaylist branch from ae0cfd3 to 281d77a Compare April 20, 2025 18:54
@xezon xezon requested a review from Mauller April 20, 2025 18:55
@xezon xezon force-pushed the xezon/fix-broken-replaylist branch from 281d77a to c249f62 Compare April 20, 2025 19:41
@xezon xezon changed the title [ZH][GEN] Fix broken replay list when it contains a replay with an unknown map [GEN][ZH] Fix broken replay list when it contains a replay with an unknown map Apr 20, 2025
Mauller
Mauller approved these changes Apr 20, 2025
View reviewed changes
Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@xezon xezon merged commit 0bc50ad into TheSuperHackers:main Apr 21, 2025
19 checks passed
@xezon xezon deleted the xezon/fix-broken-replaylist branch April 21, 2025 18:07
@xezon xezon mentioned this pull request Apr 21, 2025
Open
@DevGeniusCode DevGeniusCode mentioned this pull request Apr 25, 2025
Open
@xezon xezon modified the milestone: Stability fixes Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mauller Mauller Mauller approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right Critical Severity: Minor < Major < Critical < Blocker Gen Relates to Generals GUI For graphical user interface ZH Relates to Zero Hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xezon @Mauller @helmutbuhler