Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented Jun 7, 2025

This change fixes broken List Boxes when they contain tall rows.

This happens because a 1 byte integer value overflows in struct _ListEntryRow.

Original

shot_20250607_120059_1

Fixed

shot_20250607_115834_1

@xezon xezon added this to the Major bug fixes milestone Jun 7, 2025
@xezon xezon added Bug Something is not working right, typically is user facing Critical Severity: Minor < Major < Critical < Blocker GUI For graphical user interface labels Jun 7, 2025
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xezon xezon merged commit 1d8109f into TheSuperHackers:main Jun 9, 2025
18 checks passed
@xezon xezon deleted the xezon/fix-list-entry-height branch June 9, 2025 19:39
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something is not working right, typically is user facing Critical Severity: Minor < Major < Critical < Blocker GUI For graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replay Menu looks broken when a replay with missing map file is listed

2 participants