-
Notifications
You must be signed in to change notification settings - Fork 70
Fix Replay GUI #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix Replay GUI #398
Conversation
…here the map is not present. Also show warning when trying to open a replay with mismatched version via double-click.
I just fixed two more issues:
While I was at it, I also display those missing map names in red. I also had to factor some code into a helper function, which sadly makes the diff a bit harder to understand. I suggest code review by commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need a solution to handle inserting new strings into .csf files through an EXE, as a fallback option.
|
||
if(!success || md == NULL) | ||
{ | ||
MessageBoxOk(UnicodeString(L"MAP NOT FOUND"), UnicodeString(L"This replay cannot be loaded because the map is not present."), NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New strings should be defined strings editable in CSF or STR, not hard-coded.
{ | ||
parentReplayMenu->winHide(TRUE); | ||
MessageBoxOk(UnicodeString(L"MAP NOT FOUND"), UnicodeString(L"This replay cannot be loaded because the map is not present."), NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
Well, we will probably add more strings that need to be localized for the next patch, so I think we should handle that in a separate PR.
|
This part is merged with #732 |
This fixes two issues in the Load Replay GUI: