[GEN][ZH] Implement REPLAY NOT FOUND and MAP NOT FOUND dialogs when attempting to load a Replay that was deleted or whose map is missing

[xezon]

Merge with Rebase

• Merge after [GEN][ZH] Prevent game crash when starting a new game without a map #993
• Fixes Replay Menu looks broken when a replay with missing map file is listed #126
• Follow up for [GEN][ZH] Fix missing OLDER REPLAY VERSION dialog when double clicking a replay to load #984
• Split off of Fix Replay GUI #398

This change implements a new MAP NOT FOUND dialog when the user attempts to load a Replay whose map is missing in the user data (or game install). Originally the game would crash when trying to start a new game with a missing map.

Additionally it implements a new REPLAY NOT FOUND dialog when the user attempts to load a Replay that was deleted after the Replay Menu was opened.

This change has 2 commits. The first commit is a refactor to help implement the fix efficiently. The second commit contains new code for GameText to allow looking up localization texts with substitute texts when those localizations are not found (which they currently are not because we do not touch game data). The substitution code can be compiled out cleanly when so desired (via GameDefines.h).

TODO

• Replicate in Generals

Tip

Ignore whitespace in diff viewer to ease reviewing this change.

Dialog Image

[helmutbuhler]

Looks good. I would have preferred out parameters instead of the ReplayMapInfo struct, which is a bit weird because it has methods as a struct, doesn't have m_ prefix for the members and makes callsite code more complicated.

[helmutbuhler]

Btw, can you also 'polish' PR #760? It's also split off of #398, and I don't know how to get your approval there.

[roossienb]

With the subsitute in place, it would be great to have a follow up PR with:

• add text for when the replay is paused/unpaused
• Use substitute for Fast-forward message in Generals

[xezon]

With the subsitute in place, it would be great to have a follow up PR with:

• add text for when the replay is paused/unpaused
• Use substitute for Fast-forward message in Generals

Yes. Good idea.

[xezon]

I would have preferred out parameters instead of the ReplayMapInfo struct, which is a bit weird because it has methods as a struct, doesn't have m_ prefix for the members and makes callsite code more complicated.

Ok changed to function.

I also moved a bit more of the code into separate functions that could be reused elsewhere.

I also noticed that it is possible to attempt loading a Replay file that was deleted after the Replay Menu was opened. It then triggered the OLDER REPLAY VERSION dialog with the OK button. Pressing OK would get the game stuck loading nothing. So I added another new REPLAY NOT FOUND message to prevent that.

[aliendroid1]

What's with the title! It would better to have the title be something like "Inform when replay can't be loaded"

Also I think instead of waiting for the user to try click it and find out, maybe the titles for such replays should be made strikethrough or grayed out and the dialog information be displayed in a tooltip.

[xezon]

Also I think instead of waiting for the user to try click it and find out, maybe the titles for such replays should be made strikethrough or grayed out and the dialog information be displayed in a tooltip.

There will be a follow up change for making missing map texts dark red, created by helmut.

As for striking through replays, that is not worth it, because

1. There currently is no strikethrough font in the game
2. The Replay Menu list is populated on open. It is not refreshed when the user tinkers with his replay files while the game runs. And the chance that a user deletes his replays from outside the game after opening the Replay Menu are near 0%, because the Replay Menu has a DELETE REPLAY button. One notable feature for the Replay Menu could be a Refresh button. But that is well beyond the scope of this change and beyond what we currently aim to do: Stability fixes.

[xezon]

Note to myself: I suspect this will still break the Replay list if the file name is very long then. So we perhaps need another change that caps the length of the Replay name here. Unrelated to this Pull Request.

[xezon]

Replicated to Generals without conflicts. Commit title improved.