Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.25.1 (please TEST!) #9870

Closed
3 tasks done
Stypox opened this issue Mar 1, 2023 · 18 comments
Closed
3 tasks done

Release v0.25.1 (please TEST!) #9870

Stypox opened this issue Mar 1, 2023 · 18 comments

Comments

@Stypox
Copy link
Member

Stypox commented Mar 1, 2023

Testing for regressions

Debug APK (built by our CI in #9869): ...
Release APK (built and signed by @Stypox): NewPipe_v0.25.1_RC1_release.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases!

TODO

NewPipe Extractor version

This version of NewPipe will ship with NewPipe Extractor version v0.22.6

App changelog

New

Improved

Fixed

Development

@Yowlen
Copy link

Yowlen commented Mar 1, 2023

Went to test and the first thing I noticed was when importing a database so that I could have my settings from the main app, it refused to load thumbnails and other static images until I restarted the app manually. Video lists for channels and video comments loaded fine. Only thumbnails and other images appear affected. Testing in 0.24.1 (I'm skipping 0.25.0 due to the external player bug) confirmed it's not present there and everything loaded after import just fine.

@Stypox
Copy link
Member Author

Stypox commented Mar 1, 2023

Can you reproduce that consistently? I cannot reproduce on my phone @Yowlen

@Yowlen
Copy link

Yowlen commented Mar 1, 2023

Hmm... I went back and cleared the data and redid the import and it appears to have worked fine. So, I guess I can't reliably reproduce it. It wouldn't be the first time my phone decided to glitch out on the internet for a split second, tbh. I've had issues in other apps so it was probably that causing NewPipe to hang on that particular thread while waiting on a response from YouTube's image server that will never come. I imagine if I had waited, NewPipe's own timeout would've kicked in and fixed itself.

Sorry for a false report like that. I should've done more digging before posting. At least from the testing I can see since then, I haven't noticed any other potential regressions.

@SameenAhnaf
Copy link
Collaborator

As #9771 is solved, shouldn’t this issue be pinned instead? Most users are aware of the fact that Newpipe needs to be updated frequently.

@opusforlife2 opusforlife2 pinned this issue Mar 7, 2023
@warriormaster12

This comment was marked as off-topic.

@SameenAhnaf

This comment was marked as resolved.

@AudricV
Copy link
Member

AudricV commented Mar 8, 2023

On Android 12+, if there is no default browser available (so this would mean that the user disabled preinstalled browser(s) and doesn't have one installed) (a browser is automatically set as default and you can't set no default browser on these Android versions), NewPipe shows the No app on your device can open this toast.

On 0.25.0, the default app to open links of the domain of the URL you want to open in browser, including NewPipe, is shown in this case; otherwise a system chooser is shown, similar to Android 11 and before (the following screenshot comes from Android 14 developer preview 1):

android_14_dev_preview_1_system_chooser_no_browser_app_no_default_app_chooser

@av01d1ngx4

This comment was marked as off-topic.

@opusforlife2

This comment was marked as resolved.

@av01d1ngx4

This comment was marked as resolved.

@opusforlife2

This comment was marked as resolved.

@av01d1ngx4

This comment was marked as resolved.

@av01d1ngx4

This comment was marked as resolved.

@GerardEarley

This comment was marked as spam.

@goat-oss

This comment was marked as off-topic.

@Stypox Stypox closed this as completed Apr 3, 2023
@Stypox Stypox unpinned this issue Apr 3, 2023
@intraxit
Copy link

intraxit commented Apr 4, 2023

Has the too 'large thumbnail in grid mode' on tablet in v0.25.0 been fixed in this v.0.25.1 release ?

@tsiflimagas
Copy link
Contributor

You could just read the changelog or try the release.

@intraxit
Copy link

intraxit commented Apr 4, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests