Fixed a bug that caused erroneous updates of the playlist thumbnails #9755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Feb 7, 2023
app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistStreamDAO.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistStreamDAO.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistStreamDAO.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/dialog/PlaylistAppendDialog.java
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistManager.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review. |
SameenAhnaf
added
bug
|
@Stypox Could you perhaps take another look at this? I'm working on NewPipe as part of a project at my university and only contributions pushed by March 1st can count towards my grade. So I would very much appreciate another review. |
Stypox
requested changes
Feb 25, 2023
app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistManager.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
Thanks for the review. |
Stypox
approved these changes
Feb 26, 2023
|
Thanks for all the help and support during my course. Working with NewPipe was awesome, and I learned a lot. I had a lot of fun, and I'm definitely planning on continuing to work on it after my exams are over. Keep up the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This is an attempt to fix the bug mentioned in #9458.
Currently, NewPipe stores the
thumbnailUrlin the database. I deleted this field and replaced it with thethumbnailStreamIdfield, which stores the stream ID of the stream the thumbnail is from.Since the
thumbnailUrlis deeply rooted in the program, I had to make significant changes and perform a database migration to fix this problem.This PR makes it so that the thumbnail of a playlist is not just a url to an image, but rather is a reference to a stream in the database (which in turn contains a url to an image). This fixes the mentioned bug (since there aren't outdated thumbnails anymore), but also adds the nice feature of the playlist thumbnail getting updated automatically whenever the video's thumbnail changes.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence