Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug that caused erroneous updates of the playlist thumbnails #9755

Merged
merged 5 commits into from
Feb 26, 2023
Merged

Fixed a bug that caused erroneous updates of the playlist thumbnails #9755

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6809756
Fixed the bug by replacing the thumbnail_url with the thumbnail_strea…
Jared234 Feb 5, 2023
3ff4b71
Merge branch 'dev' into 9458_faulty_playlist_thumbnail_update
Jared234 Feb 5, 2023
5d39558
Fixed the merge conflict
Jared234 Feb 5, 2023
68ea99d
Made some small code improvements
Jared234 Feb 9, 2023
9067c77
Made some small code improvements
Jared234 Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed the merge conflict
  • Loading branch information
@Jared234
Jared234 committed Feb 5, 2023
commit 5d3955854ef5e09f83b1103d7dd07670933ad498
11 changes: 9 additions & 2 deletions app/src/main/java/org/schabi/newpipe/database/playlist/dao/PlaylistStreamDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,15 @@ default Flowable<List<PlaylistStreamEntity>> listByService(final int serviceId)
@Transaction
@Query("SELECT " + PLAYLIST_TABLE + "." + PLAYLIST_ID + ", "
+ PLAYLIST_NAME + ", "
+ PLAYLIST_TABLE + "." + PLAYLIST_THUMBNAIL_URL + ", "
+ "COALESCE(COUNT(" + JOIN_PLAYLIST_ID + "), 0) AS " + PLAYLIST_STREAM_COUNT + ", "

+ " CASE WHEN " + PLAYLIST_THUMBNAIL_STREAM_ID + " = -1"
+ " THEN " + "'" + DEFAULT_THUMBNAIL + "'"
+ " ELSE (SELECT " + STREAM_THUMBNAIL_URL
+ " FROM " + STREAM_TABLE
+ " WHERE " + STREAM_TABLE + "." + STREAM_ID + " = " + PLAYLIST_THUMBNAIL_STREAM_ID
+ " ) END AS " + PLAYLIST_THUMBNAIL_URL

+ ", COALESCE(COUNT(" + JOIN_PLAYLIST_ID + "), 0) AS " + PLAYLIST_STREAM_COUNT + ", "
Jared234 marked this conversation as resolved.
Show resolved Hide resolved
+ "COALESCE(SUM(" + STREAM_URL + " = :streamUrl), 0) AS "
+ PLAYLIST_TIMES_STREAM_IS_CONTAINED

Expand Down