Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove partially watched videos from the 'Whats new' feed #9747

Merged

Conversation

Jared234
Copy link
Contributor

@Jared234 Jared234 commented Feb 4, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • added the option to remove partially watched streams from the "What's new" feed
  • the options to hide played, partially played or future items have been merged into one checkbox menu

Before/After Screenshots/Screen Record

  • Before:
    Screenshot_20230204-195026

  • After:
    Screenshot_20230204-184944
    Screenshot_20230204-184949

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface feed Issue is related to the feed labels Feb 4, 2023
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice change!

@SameenAhnaf
Copy link
Collaborator

This PR solves #8617 too. Thanks!

@Jared234 Jared234 requested a review from Stypox February 9, 2023 20:43
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested a bit and it works

@Stypox Stypox merged commit 2e3490b into TeamNewPipe:dev Feb 28, 2023
@AudricV AudricV changed the title Added option to remove partially watched videos from the 'Whats new' feed Add option to remove partially watched videos from the 'Whats new' feed Feb 28, 2023
@Jared234
Copy link
Contributor Author

Thanks for all of the reviews : )

@Stypox Stypox mentioned this pull request Mar 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to remove partially watched videos from the 'Whats new' feed.
4 participants