Handle duplicate streams in the "Add to playlist" dialog

[Jared234]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Indicator added to the "Add to playlist" dialog to alert users if they are attempting to add a duplicate stream
• AlertDialog opens if a user tries to add the same stream to the same playlist, allowing them to confirm or cancel their action

This helps prevent users from accidentally adding the same stream multiple times to their playlist, but stills allows them do it if they intend to do so.

Before/After Screenshots/Screen Record

• Before: The "Add to playlist" dialog did not handle duplicate streams properly. When a user attempted to add a duplicate stream, they were not warned or given any indication that the stream was a duplicate. This allowed users to unknowingly add the same stream multiple times to their playlist.
• After:
  If a user attempts to add a stream to a playlist twice, the playlist will be grayed out to indicate that it is a duplicate:

If a user attempts to add a stream to their playlist that is already in the playlist anyway, a dialog will appear to alert them that the stream is a duplicate and ask them if they want to proceed with adding it to the playlist:

Fixes the following issue(s)

• Fixes Show a warning before adding a duplicate video to a playlist #4186

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Jared234]

I was wondering if it would be possible to rerun the pipeline. All of the tests work locally, and in this pipeline the operation was cancelled without any error messages. I don't think there is a problem with the code, so could you please rerun it @AudricV?

Thank you for your help.

[opusforlife2]

I don't think the AlertDialog is needed? Since the user has been warned that the item will be duplicated, and there is a visual indication as well, the dialog seems overkill.

Also, for users who intentionally want to add duplicates, this would be an annoying extra step each and every time they go through with it.

Instead of an AlertDialog, I would rather go with a toast saying "Duplicate added", which also informs the user that they did indeed go ahead and add a duplicate, but doesn't need a tap for confirmation. For users who ignore/don't read the warning about the greyed out playlists, the toast would act as a second warning.

[Jared234]

I see your point. The only downside to removing this dialog would be that users would not know how many duplicate videos are already in the playlist. At first glance, though, I don't know why anyone would need that information.... So I will change it.

[Jared234]

I removed the duplicate dialog and if a video was already at least once in the playlist I replaced the toast message "Playlisted" with "Playlisted duplicate".

[opusforlife2]

how many duplicate videos are already in the playlist

"Duplicate added x time(s)"

There you go, if needed.

[Stypox]

Thank you! I agree with @opusforlife2 on the fact that a dialog is not needed and a toast is better. Let me know if the changes I requested for the list view are comprehensible.

[Stypox]

I pushed two more small commits and tested thoroughly. It seems to work well. Thank you!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication