Skip to content

Conversation

@Julusian
Copy link
Member

@Julusian Julusian commented Sep 23, 2024

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

This builds upon and includes the changes from #1262

New Behavior

Studio package manager config can now be setup by the blueprint studio applyConfig method.
They utilise the same ObjectWithOverrides structure as elsewhere.

Note: this does not include previewContainerIds or thumbnailContainerIds, that will likely follow in a later PR.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 34.73684% with 62 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (1729c7d) to head (e8e1a28).
Report is 67 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/migration/X_X_X.ts 52.08% 23 Missing ⚠️
...ations/packageManager/expectedPackages/generate.ts 0.00% 18 Missing ⚠️
...ons/packageManager/expectedPackages/publication.ts 0.00% 9 Missing ⚠️
...r/publications/packageManager/packageContainers.ts 0.00% 5 Missing ⚠️
...ns/pieceContentStatusUI/checkPieceContentStatus.ts 55.55% 4 Missing ⚠️
meteor/server/api/rest/v1/typeConversion.ts 0.00% 1 Missing ⚠️
meteor/server/api/studio/api.ts 0.00% 1 Missing ⚠️
...server/publications/pieceContentStatusUI/common.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1263      +/-   ##
=============================================
- Coverage      60.71%   60.61%   -0.10%     
=============================================
  Files            459      458       -1     
  Lines          78239    78436     +197     
  Branches        4433     4898     +465     
=============================================
+ Hits           47499    47542      +43     
- Misses         30520    30752     +232     
+ Partials         220      142      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian force-pushed the upstream/config-package-manager-from-blueprints branch from efb39b3 to bcb9edf Compare September 27, 2024 12:42
@mint-dewit mint-dewit added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Sep 30, 2024
@Julusian Julusian force-pushed the upstream/config-package-manager-from-blueprints branch from bcb9edf to 685364d Compare October 9, 2024 09:41
@Julusian Julusian marked this pull request as ready for review October 9, 2024 09:54
@Julusian Julusian requested a review from a team as a code owner October 9, 2024 09:54
@nytamin nytamin merged commit 5987326 into Sofie-Automation:release52 Oct 16, 2024
@Julusian Julusian deleted the upstream/config-package-manager-from-blueprints branch October 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants